Page MenuHomeSoftware Heritage

Make sure that cli tests don't leave subcommands hanging
ClosedPublic

Authored by olasd on Nov 21 2019, 4:21 PM.

Details

Summary

The current tests depend on order of execution: if the main tests run before the
db tests, the addition of extra subcommands makes them fail.

Depends on D2328
Depends on D2327 (kinda)

Test Plan

tox -e py3-core-db (running both core and db tests, in that order)
would fail before this diff

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 21 2019, 4:21 PM
vlorentz requested changes to this revision.Nov 21 2019, 4:22 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
conftest.py
12–18

It should have a docstring, because it's not clear what it does based on the name or code.

This revision now requires changes to proceed.Nov 21 2019, 4:22 PM
olasd updated this revision to Diff 8032.Nov 21 2019, 4:30 PM

Add docstring to swhmain fixture

vlorentz accepted this revision.Nov 21 2019, 4:36 PM
This revision is now accepted and ready to land.Nov 21 2019, 4:36 PM