Page MenuHomeSoftware Heritage
Differential D2330

Make sure that cli tests don't leave subcommands hanging
ClosedPublic
Actions

Authored by olasd on Nov 21 2019, 4:21 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCORE6f27106e572e: Make sure that cli tests don't leave subcommands hanging
Summary

The current tests depend on order of execution: if the main tests run before the
db tests, the addition of extra subcommands makes them fail.

Depends on D2328
Depends on D2327 (kinda)

Test Plan

tox -e py3-core-db (running both core and db tests, in that order)
would fail before this diff

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 21 2019, 4:21 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2019, 4:21 PM
olasd added a child revision: D2331: Make the main py3 tox environment an alias/merge of other test environments.Nov 21 2019, 4:21 PM
vlorentz requested changes to this revision.Nov 21 2019, 4:22 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
conftest.py
11–17

It should have a docstring, because it's not clear what it does based on the name or code.

This revision now requires changes to proceed.Nov 21 2019, 4:22 PM
swh-public-ci added a comment.Nov 21 2019, 4:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/355/ for more details.

Harbormaster completed remote builds in B9286: Diff 8028.Nov 21 2019, 4:27 PM
olasd updated this revision to Diff 8032.Nov 21 2019, 4:30 PM

Add docstring to swhmain fixture

swh-public-ci added a comment.Nov 21 2019, 4:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/359/ for more details.

Harbormaster completed remote builds in B9290: Diff 8032.Nov 21 2019, 4:35 PM
vlorentz accepted this revision.Nov 21 2019, 4:36 PM
This revision is now accepted and ready to land.Nov 21 2019, 4:36 PM
Closed by commit rDCORE6f27106e572e: Make sure that cli tests don't leave subcommands hanging (authored by olasd). · Explain WhyNov 21 2019, 5:03 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDCORE6f27106e572e: Make sure that cli tests don't leave subcommands hanging.

Revision Contents
Changeset List

PathSize
14 lines
swh/
core/
db/
tests/
5 lines
tests/
18 lines

Diff 8040

View Options

conftest.py

Loading...
View Options

swh/core/db/tests/test_cli.py

Loading...
View Options

swh/core/tests/test_cli.py

Loading...
About · Developer information · Legal