This allows registering of workers' task types within the scheduler backend.
Those are declared in their respective setup.py's entrypoint under the section [swh.workers] .
(This is moved from swh.lister to swh.scheduler).
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDSCH93585727b8e0: swh.scheduler.cli: Add `swh scheduler task-type register` cli
tox
Diff Detail
Diff Detail
- Repository
- rDSCH Scheduling utilities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9112 Build 13324: tox-on-jenkins Jenkins Build 13323: arc lint + arc unit
Event Timeline
| swh/scheduler/cli/task_type.py | ||
|---|---|---|
| 80 | I did not find a way to make that actually a "choice". | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/307/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/308/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/309/ for more details.
| swh/scheduler/__init__.py | ||
|---|---|---|
| 74 ↗ | (On Diff #7883) | May I suggest to find a better name here? I mean load_xxx_module makes the reader think this function will load these plugin python modules (aka import them) which it does not. It loads known swh.workers plugin declarations. In fact, I'm not even sure this function is useful. The diffs below like - for entrypoint in pkg_resources.iter_entry_points('swh.workers'):
+ for entrypoint in load_worker_modules().values():looks not so useful in terms of code clarity/readability. |
| swh/scheduler/cli/task_type.py | ||
| 35 | naming again: these are not worker modules, and not even plugin (python) modules, but worker plugin descriptions. | |
| 92 | /nitpicky/ this worker_modules local variable is useless IMHO. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/310/ for more details.
| swh/scheduler/cli/task_type.py | ||
|---|---|---|
| 80 | It's now a real "choice". | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/311/ for more details.