Page MenuHomeSoftware Heritage

add /last sub-endpoint to only return destination in walks
ClosedPublic

Authored by zack on Nov 16 2019, 3:14 PM.

Diff Detail

Repository
rDGRPH Compressed graph representation
Branch
feature/random-walk-last
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9085
Build 13289: tox-on-jenkinsJenkins
Build 13288: arc lint + arc unit

Event Timeline

  • REST API doc: document /last for all applicable methods
  • add /last sub-endpoint to only return destination in walks
  • REST API doc: document /last for all applicable methods
seirl requested changes to this revision.Nov 18 2019, 1:36 PM
seirl added inline comments.
swh/graph/tests/test_api_client.py
111

I don't think it's useful to do copy() if you're assigning it to kwargs anyway, the old value will just get garbage collected. Either don't copy() or use a different variable name maybe?

134

ditto

This revision now requires changes to proceed.Nov 18 2019, 1:36 PM
zack marked 2 inline comments as done.
  • add /last sub-endpoint to only return destination in walks
  • REST API doc: document /last for all applicable methods
swh/graph/tests/test_api_client.py
111

lol, yeah, I meant to use a different variable name here :-)

This revision is now accepted and ready to land.Nov 18 2019, 1:53 PM
  • add /last sub-endpoint to only return destination in walks
  • REST API doc: document /last for all applicable methods