Paths

Table of Contentst

Differential D2289

add /last sub-endpoint to only return destination in walks
ClosedPublic
Actions

Authored by zack on Nov 16 2019, 3:14 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T2084: swh-graph: add /last endpoint variants to the REST API

Commits

rDGRPH97e84765c276: REST API doc: document /last for all applicable methods
rDGRPH51d6b602c3e8: add /last sub-endpoint to only return destination in walks

Summary

works for both random and non-random walks

Closes T2084

Test Plan

tox

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Nov 16 2019, 3:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/101/ for more details.

Harbormaster completed remote builds in B9060: Diff 7872.Nov 16 2019, 3:16 PM

REST API doc: document /last for all applicable methods

Harbormaster failed remote builds in B9064: Diff 7875!Nov 16 2019, 7:32 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/103/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/103/console

add /last sub-endpoint to only return destination in walks
REST API doc: document /last for all applicable methods

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/104/ for more details.

Harbormaster completed remote builds in B9065: Diff 7876.Nov 16 2019, 8:04 PM

seirl requested changes to this revision.Nov 18 2019, 1:36 PM

seirl added inline comments.

swh/graph/tests/test_api_client.py
111	I don't think it's useful to do `copy()` if you're assigning it to `kwargs` anyway, the old value will just get garbage collected. Either don't `copy()` or use a different variable name maybe?
134	ditto

This revision now requires changes to proceed.Nov 18 2019, 1:36 PM

add /last sub-endpoint to only return destination in walks
REST API doc: document /last for all applicable methods

swh/graph/tests/test_api_client.py
111	lol, yeah, I meant to use a different variable name here :-)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/107/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/107/console

Harbormaster failed remote builds in B9083: Diff 7891!Nov 18 2019, 1:51 PM

seirl accepted this revision.Nov 18 2019, 1:53 PM

This revision is now accepted and ready to land.Nov 18 2019, 1:53 PM

add /last sub-endpoint to only return destination in walks
REST API doc: document /last for all applicable methods

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/108/ for more details.

Harbormaster completed remote builds in B9085: Diff 7892.Nov 18 2019, 1:55 PM

Closed by commit rDGRPH51d6b602c3e8: add /last sub-endpoint to only return destination in walks (authored by zack). · Explain WhyNov 18 2019, 1:56 PM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDGRPH51d6b602c3e8: add /last sub-endpoint to only return destination in walks.

zack added a commit: rDGRPH97e84765c276: REST API doc: document /last for all applicable methods.

Revision Contents
Changeset List

Path

Size

docs/

7 lines

swh/

graph/

12 lines

server/

13 lines

tests/

test_api_client.py

36 lines

Diff 7893

docs/api.rst

Loading...

swh/graph/client.py

Loading...

swh/graph/server/app.py

Loading...

swh/graph/tests/test_api_client.py

Loading...