Differential D2284

Rename scroll_token to page_token/next_page_token.
ClosedPublic
Actions

Authored by vlorentz on Nov 15 2019, 2:42 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDSEA71f6ae6bca7d: Rename scroll_token to page_token/next_page_token.

Summary

For uniformity with the indexer-storage.

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 15 2019, 2:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 15 2019, 2:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/20/ for more details.

Harbormaster completed remote builds in B9045: Diff 7856.Nov 15 2019, 2:44 PM

douardda accepted this revision.Nov 18 2019, 1:41 PM

This revision is now accepted and ready to land.Nov 18 2019, 1:41 PM

Closed by commit rDSEA71f6ae6bca7d: Rename scroll_token to page_token/next_page_token. (authored by vlorentz). · Explain WhyNov 19 2019, 4:16 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEA71f6ae6bca7d: Rename scroll_token to page_token/next_page_token..

Revision Contents
Changeset List

Path

Size

swh/

search/

elasticsearch.py

26 lines

in_memory.py

20 lines

tests/

test_cli.py

6 lines

test_search.py

30 lines

utils.py

12 lines

Diff 7915

View Options

swh/search/elasticsearch.py

View Options

swh/search/in_memory.py

View Options

swh/search/tests/test_cli.py

View Options

swh/search/tests/test_search.py

View Options

Rename scroll_token to page_token/next_page_token.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7915

swh/search/elasticsearch.py

swh/search/in_memory.py

swh/search/tests/test_cli.py

swh/search/tests/test_search.py

swh/search/utils.py

Rename scroll_token to page_token/next_page_token.
ClosedPublic
Actions

Revision Contents
Changeset List