Differential D2218

cli: fix max-message handling in the journal-client command
ClosedPublic
Actions

Authored by douardda on Nov 5 2019, 12:23 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDXfe884ef83e9c: cli: fix max-message handling in the journal-client command

Summary

the max_messages value must be passed to the client constructor, otherwise
it will hang forever for max-messages<20 (eg. in tests).

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 8814
Build 12846: tox-on-jenkins	Jenkins
Build 12845: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 5 2019, 12:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 5 2019, 12:23 PM

No, the right fix is D2205

This revision now requires changes to proceed.Nov 5 2019, 12:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/641/ for more details.

Harbormaster completed remote builds in B8814: Diff 7647.Nov 5 2019, 12:26 PM

vlorentz accepted this revision.Nov 5 2019, 2:56 PM

This revision is now accepted and ready to land.Nov 5 2019, 2:56 PM

reformat for style consistency in the function

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/642/ for more details.

Harbormaster completed remote builds in B8817: Diff 7650.Nov 5 2019, 3:10 PM

Closed by commit rDCIDXfe884ef83e9c: cli: fix max-message handling in the journal-client command (authored by douardda). · Explain WhyNov 5 2019, 3:11 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCIDXfe884ef83e9c: cli: fix max-message handling in the journal-client command.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

cli.py

3 lines

Diff 7647

View Options

cli: fix max-message handling in the journal-client commandClosedPublicActions