Page MenuHomeSoftware Heritage

cli: fix max-message handling in the journal-client command
ClosedPublic

Authored by douardda on Tue, Nov 5, 12:23 PM.

Details

Summary

the max_messages value must be passed to the client constructor, otherwise
it will hang forever for max-messages<20 (eg. in tests).

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Nov 5, 12:23 PM
vlorentz requested changes to this revision.Tue, Nov 5, 12:25 PM
vlorentz added a subscriber: vlorentz.

No, the right fix is D2205

This revision now requires changes to proceed.Tue, Nov 5, 12:25 PM
vlorentz accepted this revision.Tue, Nov 5, 2:56 PM
This revision is now accepted and ready to land.Tue, Nov 5, 2:56 PM
douardda updated this revision to Diff 7650.Tue, Nov 5, 3:07 PM

reformat for style consistency in the function