Differential D22

T293 - Add relative directory browsing view
ClosedPublic
Actions

Authored by jbertran on May 3 2016, 12:07 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T293: Open /browse/directory/<sha1_git>/[<path>/] view

Commits

R65:eb1ff578ad05: /directory/ browsing view: rename entrypath parameter to path
R65:fdf1ee7a3e8f: browsing view: add /browse/directory/<sha1_git>/[<path>/] to the…
R65:6ab97264e0ea: browse test: remove print, fix testing get request paths to match the test…
R65:13866e2abb84: .gitignore: now ignoring emacs temp files
R65:45b34efedd0d: service: lookup_directory_with_path raises a NotFoundExc the entry queried is…
rDWAPPSeb1ff578ad05: /directory/ browsing view: rename entrypath parameter to path
rDWAPPS6ab97264e0ea: browse test: remove print, fix testing get request paths to match the test…
rDWAPPSfdf1ee7a3e8f: browsing view: add /browse/directory/<sha1_git>/[<path>/] to the…
rDWAPPS45b34efedd0d: service: lookup_directory_with_path raises a NotFoundExc the entry queried is…
rDWAPPS13866e2abb84: .gitignore: now ignoring emacs temp files

Summary

service: lookup_directory_with_path raises a NotFoundExc the entry queried is not found

browsing view: add /browse/directory/<sha1_git>/[<path>/] to the /browse/directory route, add tests accordingly.

Test Plan

N/A

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbertran updated this revision to Diff 57.May 3 2016, 12:07 PM

jbertran added a task: T293: Open /browse/directory/<sha1_git>/[<path>/] view.

jbertran retitled this revision from to T293 - Add relative directory browsing view.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

jbertran added reviewers: ardumont, zack.

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 3 2016, 12:07 PM

A couple of minor points that could be changed, but I've only looked at details.
@ardumont: can you have a look at the rest?

swh/web/ui/tests/views/test_browse.py
343 ↗	(On Diff #57)	what does a print() do in a test case? please remove it
swh/web/ui/views/browse.py
212–213 ↗	(On Diff #57)	two minor points here: "entrypath" could really be called "path", as there is no ambiguity do we really need two separate routes? can't <path:path> default to None, and be tested in the remainder of the code if it is None or not to disambiguate? (note: I'm not sure of the answer w.r.t. werkzeug's semantics, but it's worth checking)

jbertran added inline comments.May 3 2016, 12:37 PM

swh/web/ui/views/browse.py
212–213 ↗	(On Diff #57)	From testing it with the /directory/ route commented out in favor of the /directory/<path>/ route, this actually breaks both routes - I suspect this is because the separating '/'s are necessary.

zack added a subscriber: zack.May 3 2016, 12:53 PM

zack added inline comments.

swh/web/ui/views/browse.py
212–213 ↗	(On Diff #57)	Gah. OK, never mind then.

In D22#313, @zack wrote:

A couple of minor points that could be changed, but I've only looked at details.
@ardumont: can you have a look at the rest?

yes, i will

ardumont added inline comments.May 3 2016, 2:09 PM

swh/web/ui/tests/views/test_browse.py
345 ↗	(On Diff #57)	It's a path to a 'file' here ^^
383 ↗	(On Diff #57)	It's path to a dir here ^^.

browse test: remove print, fix testing get request paths to match
/directory/ browsing view: rename entrypath parameter to path

Herald edited edge metadata. · View Herald TranscriptMay 3 2016, 2:17 PM

ardumont accepted this revision.May 3 2016, 3:29 PM

ardumont edited edge metadata.

This revision is now accepted and ready to land.May 3 2016, 3:29 PM

.gitignore: now ignoring emacs temp files
service: lookup_directory_with_path raises a NotFoundExc the entry
browsing view: add /browse/directory/<sha1_git>/[<path>/] to the
browse test: remove print, fix testing get request paths to match
/directory/ browsing view: rename entrypath parameter to path

This revision now requires review to proceed.May 3 2016, 3:52 PM

ardumont accepted this revision.May 3 2016, 3:54 PM

ardumont edited edge metadata.

This revision is now accepted and ready to land.May 3 2016, 3:54 PM

Closed by commit rDWAPPS13866e2abb84: .gitignore: now ignoring emacs temp files (authored by jbertran). · Explain WhyMay 3 2016, 3:55 PM

This revision was automatically updated to reflect the committed changes.

zack edited edge metadata.May 30 2016, 3:20 PM

zack changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

4 lines

Diff 60

.gitignore

Loading...