Paths

Table of Contentst

Differential D2195

Bound the value of the 'limit' parameter to origin-search.
ClosedPublic
Actions

Authored by vlorentz on Oct 29 2019, 5:10 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDWAPPS7856c27b5cef: Bound the value of the 'limit' parameter to origin-search.

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-search-limit

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8733
Build 12725: Cypress tests for swh-web diffs	Jenkins
Build 12724: tox-on-jenkins	Jenkins
Build 12723: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 29 2019, 5:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2019, 5:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/746/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/348/ for more details.

Harbormaster completed remote builds in B8689: Diff 7483.Oct 29 2019, 5:20 PM

I agree that the limit parameter should have an upper bound but a value of 100 feels too low for me.

Also, the browse endpoint for searching origins should be updated the same way (see https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/browse/views/origin.py$181).
This also means that we should have a variable somewhere holding that upper bound value for the limit parameter of origin search.

swh/web/api/views/origin.py
197–198	docstring should be updated with the limit upper bound here.
222	A value of `100` seems too low for a limit upper bound. I think you could set it to `1000` or maybe even `10000` depending on how fast elasticsearch returns a search query response.

This revision now requires changes to proceed.Oct 29 2019, 5:31 PM

doc
max 1000
browse

vlorentz marked 2 inline comments as done.Oct 30 2019, 5:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/749/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/749/console

Harbormaster failed remote builds in B8733: Diff 7528!Oct 30 2019, 5:18 PM

anlambert requested changes to this revision.Oct 31 2019, 3:51 PM

anlambert added inline comments.

swh/web/tests/api/views/test_origin.py
477	The test needs to be updated after the increase of limit bound to 1000.

This revision now requires changes to proceed.Oct 31 2019, 3:51 PM

update test

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/750/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/352/ for more details.

Harbormaster completed remote builds in B8781: Diff 7618.Nov 4 2019, 12:26 PM

anlambert accepted this revision.Nov 4 2019, 1:18 PM

This revision is now accepted and ready to land.Nov 4 2019, 1:18 PM

rebase

This revision was landed with ongoing or failed builds.Nov 4 2019, 1:20 PM

Closed by commit rDWAPPS7856c27b5cef: Bound the value of the 'limit' parameter to origin-search. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS7856c27b5cef: Bound the value of the 'limit' parameter to origin-search..

Harbormaster failed remote builds in B8788: Diff 7625!Nov 4 2019, 1:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/751/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/751/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/353/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/353/console

Revision Contents
Changeset List

Path

Size

swh/

web/

api/

views/

3 lines

browse/

views/

2 lines

tests/

api/

views/

14 lines

Diff 7528

swh/web/api/views/origin.py

Loading...

swh/web/browse/views/origin.py

Loading...

swh/web/tests/api/views/test_origin.py

Loading...