Page MenuHomeSoftware Heritage
Differential D2192

Add 'with_visit' filter to origin search.
ClosedPublic
Actions

Authored by vlorentz on Oct 29 2019, 4:00 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSEA0502e0e1ff06: Add 'with_visit' filter to origin search.
Summary

This also adds a 'has_visits' boolean field to origin documents,
which will be set to True as soon as a visit for the origin is
seen.

Diff Detail

Repository
rDSEA Archive search
Branch
with_visit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8678
Build 12631: tox-on-jenkinsJenkins
Build 12630: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 29 2019, 4:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2019, 4:00 PM
vlorentz added a child revision: D2193: Make the journal client set has_visits on origin documents..Oct 29 2019, 4:01 PM
swh-public-ci added a comment.Oct 29 2019, 4:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/4/ for more details.

Harbormaster completed remote builds in B8678: Diff 7472.Oct 29 2019, 4:02 PM
vlorentz updated this revision to Diff 7475.Oct 29 2019, 4:11 PM

remove useless store:True from mapping.

swh-public-ci added a comment.Oct 29 2019, 4:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/7/ for more details.

Harbormaster completed remote builds in B8681: Diff 7475.Oct 29 2019, 4:13 PM
olasd accepted this revision.Oct 29 2019, 4:55 PM
olasd added a subscriber: olasd.

This diff looks fine, but it makes me wonder: how would we apply mapping updates in production?

It'd be nice to have this documented before we actually need to do it.

This revision is now accepted and ready to land.Oct 29 2019, 4:55 PM
vlorentz added a comment.Oct 29 2019, 5:11 PM

I have absolutely no idea.

vlorentz mentioned this in D2193: Make the journal client set has_visits on origin documents..Oct 29 2019, 5:15 PM
Closed by commit rDSEA0502e0e1ff06: Add 'with_visit' filter to origin search. (authored by vlorentz). · Explain WhyOct 30 2019, 10:36 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSEA0502e0e1ff06: Add 'with_visit' filter to origin search..

Revision Contents
Changeset List

PathSize
swh/
search/
21 lines
4 lines
tests/
28 lines

Diff 7472

View Options

swh/search/elasticsearch.py

Loading...
View Options

swh/search/in_memory.py

Loading...
View Options

swh/search/tests/test_search.py

Loading...
About · Developer information · Legal