Page MenuHomeSoftware Heritage
Differential D2190

model: make model entities frozen
ClosedPublic
Actions

Authored by douardda on Oct 29 2019, 2:36 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMOD7564596424a4: model: make model entities frozen
Summary

we do not really need them to be mutable, plus we gain their instances now
being hashable, so we can add them in set() for example.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 29 2019, 2:36 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2019, 2:36 PM
douardda added a child revision: D2191: Add a test data generator module.Oct 29 2019, 2:37 PM
swh-public-ci added a comment.Oct 29 2019, 2:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/143/ for more details.

Harbormaster completed remote builds in B8672: Diff 7466.Oct 29 2019, 2:38 PM
vlorentz accepted this revision.Oct 29 2019, 2:39 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/hypothesis_strategies.py
97–101

I'd like this to be two different statement (one for draw + builds, one for evolve), for readability.

This revision is now accepted and ready to land.Oct 29 2019, 2:39 PM
douardda added inline comments.Oct 29 2019, 2:42 PM
swh/model/hypothesis_strategies.py
97–101

ok but what about the combo in test_todict_origin_visits() below then ;-)

vlorentz added inline comments.Oct 29 2019, 2:47 PM
swh/model/hypothesis_strategies.py
97–101

* shrug *

douardda updated this revision to Diff 7468.Oct 29 2019, 2:48 PM

updated according comments

swh-public-ci added a comment.Oct 29 2019, 2:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/145/ for more details.

Harbormaster completed remote builds in B8674: Diff 7468.Oct 29 2019, 2:49 PM
Closed by commit rDMOD7564596424a4: model: make model entities frozen (authored by douardda). · Explain WhyOct 30 2019, 9:27 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDMOD7564596424a4: model: make model entities frozen.

Revision Contents
Changeset List

PathSize
swh/
model/
8 lines
24 lines
tests/
6 lines

Diff 7485

View Options

swh/model/hypothesis_strategies.py

Loading...
View Options

swh/model/model.py

Loading...
View Options

swh/model/tests/test_model.py

Loading...
About · Developer information · Legal