This avoids the need for libsystemd-dev when installing swh.core's cli component
Details
Details
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/324/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/324/console
Comment Actions
BUILD has failed
jenkins reports:
==================================== ERRORS ====================================
_ ERROR collecting .tox/py3-core/lib/python3.5/site-packages/swh/core/tests/test_logger.py _
.tox/py3-core/lib/python3.5/site-packages/swh/core/tests/test_logger.py:13: in <module>
from swh.core import logger
.tox/py3-core/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:142: in exec_module
exec(co, module.__dict__)
.tox/py3-core/lib/python3.5/site-packages/swh/core/logger.py:9: in <module>
from systemd.journal import JournalHandler as _JournalHandler, send
E ImportError: No module named 'systemd'
_ ERROR collecting .tox/py3-core/lib/python3.5/site-packages/swh/core/tests/test_logger.py _
ImportError while importing test module '/home/jenkins/workspace/DCORE/tox/.tox/py3-core/lib/python3.5/site-packages/swh/core/tests/test_logger.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.tox/py3-core/lib/python3.5/site-packages/swh/core/tests/test_logger.py:13: in <module>
from swh.core import logger
.tox/py3-core/lib/python3.5/site-packages/swh/core/logger.py:9: in <module>
from systemd.journal import JournalHandler as _JournalHandler, send
E ImportError: No module named 'systemd'I guess, we need to try except the tests for the test_logger module if the import fails (or something?)
Thanks for that btw.
Comment Actions
- Move systemd-python to an optional logging subpackage
- Add missing requirements-test in sdist
- Move Click to base requirements
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/325/ for more details.