Note that this adds a dependency swh-model -> dulwich.
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDMOD6e7c3dac3c6c: mypi.ini: remove left-over "false positive" comment from dulwich exclude
rDMODb2d8bbf56923: setup.py: move CLI dependencies to a dedicated swh-model[cli] subpackage
rDMODa9af3e7c66c0: swh identify: add support to compute snapshot PIDs of on-disk git repo
tox swh identify --type snapshot /dir/to/a/local/git/repo
Diff Detail
- Repository
- rDMOD Data model
- Branch
- feature/identify-snapshots
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8063 Build 11624: tox-on-jenkins Jenkins Build 11623: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/128/ for more details.
Would it be possible to make that extra dependency on dulwich optional, e.g. only installed when requesting swh.model[identify]?
Apart from that the implementation looks fine to me.
mypy.ini | ||
---|---|---|
10 | I guess this is not a false positive. :) |
- setup.py: move CLI dependencies to a dedicated swh-model[cli] subpackage
- mypi.ini: remove left-over "false positive" comment from dulwich exclude
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/130/ for more details.
Good one. How about swh.model[cli] instead though?
That is what I've now implemented in this iteration of the diff.
(It's the first time I fiddle with a setup.py sub-package, so watch out as I might've forgotten to update some parts...)
Even better.
That is what I've now implemented in this iteration of the diff.
(It's the first time I fiddle with a setup.py sub-package, so watch out as I might've forgotten to update some parts...)
I think this is fine.