Page MenuHomeSoftware Heritage
Differential D2034

Write objects to the journal only if they don't exist yet.
ClosedPublic
Actions

Authored by vlorentz on Sep 24 2019, 3:13 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSTOCcbc47c487306: Write objects to the journal only if they don't exist yet.
rDSTOcbc47c487306: Write objects to the journal only if they don't exist yet.
Summary
  • spares some bandwidth/processing time
  • aligns {content,directory,release,revision}_add on what {snapshot,origin}_add already does

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 24 2019, 3:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2019, 3:13 PM
swh-public-ci added a comment.Sep 24 2019, 3:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/641/ for more details.

Harbormaster completed remote builds in B7936: Diff 6824.Sep 24 2019, 3:18 PM
olasd accepted this revision.Sep 27 2019, 12:08 PM
olasd added a subscriber: olasd.
olasd added inline comments.
swh/storage/in_memory.py
787–790

This looks redundant

This revision is now accepted and ready to land.Sep 27 2019, 12:08 PM
vlorentz added inline comments.Sep 27 2019, 1:50 PM
swh/storage/in_memory.py
787–790

Good catch. Same issue with the other methods.

vlorentz updated this revision to Diff 6841.Sep 27 2019, 1:55 PM
swh/storage/in_memory.py
787–790

Actually, no, only in this one.

Harbormaster failed remote builds in B7962: Diff 6841!Sep 27 2019, 2:47 PM
swh-public-ci added a comment.Sep 27 2019, 2:47 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/645/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/645/console

Harbormaster completed remote builds in B7962: Diff 6841.Sep 30 2019, 11:53 AM
swh-public-ci added a comment.Sep 30 2019, 11:53 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/653/ for more details.

vlorentz updated this revision to Diff 6859.Sep 30 2019, 12:06 PM

rebase

This revision was landed with ongoing or failed builds.Sep 30 2019, 12:06 PM
Closed by commit rDSTOcbc47c487306: Write objects to the journal only if they don't exist yet. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOcbc47c487306: Write objects to the journal only if they don't exist yet..
Harbormaster failed remote builds in B8000: Diff 6859!Sep 30 2019, 12:06 PM
swh-public-ci added a comment.Sep 30 2019, 12:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/654/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/654/console

vlorentz mentioned this in D2084: swh.storage.filter: Add filtering storage implementation.Oct 8 2019, 2:55 PM
vlorentz added a commit: rDSTOCcbc47c487306: Write objects to the journal only if they don't exist yet..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
33 lines
62 lines
tests/
79 lines

Diff 6860

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal