Page MenuHomeSoftware Heritage

Write objects to the journal only if they don't exist yet.
ClosedPublic

Authored by vlorentz on Tue, Sep 24, 3:13 PM.

Details

Summary
  • spares some bandwidth/processing time
  • aligns {content,directory,release,revision}_add on what {snapshot,origin}_add already does

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Sep 24, 3:13 PM
olasd accepted this revision.Fri, Sep 27, 12:08 PM
olasd added a subscriber: olasd.
olasd added inline comments.
swh/storage/in_memory.py
787–790

This looks redundant

This revision is now accepted and ready to land.Fri, Sep 27, 12:08 PM
vlorentz added inline comments.Fri, Sep 27, 1:50 PM
swh/storage/in_memory.py
787–790

Good catch. Same issue with the other methods.

vlorentz updated this revision to Diff 6841.Fri, Sep 27, 1:55 PM
swh/storage/in_memory.py
787–790

Actually, no, only in this one.

This revision was landed with ongoing or failed builds.Mon, Sep 30, 12:06 PM
This revision was automatically updated to reflect the committed changes.