Page MenuHomeSoftware Heritage

Write objects to the journal only if they don't exist yet.
ClosedPublic

Authored by vlorentz on Sep 24 2019, 3:13 PM.

Details

Summary
  • spares some bandwidth/processing time
  • aligns {content,directory,release,revision}_add on what {snapshot,origin}_add already does

Diff Detail

Repository
rDSTO Storage manager
Branch
write-journal-only-if-exists
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7936
Build 11430: tox-on-jenkinsJenkins
Build 11429: arc lint + arc unit

Event Timeline

olasd added a subscriber: olasd.
olasd added inline comments.
swh/storage/in_memory.py
779–784

This looks redundant

This revision is now accepted and ready to land.Sep 27 2019, 12:08 PM
swh/storage/in_memory.py
779–784

Good catch. Same issue with the other methods.

swh/storage/in_memory.py
779–784

Actually, no, only in this one.

This revision was landed with ongoing or failed builds.Sep 30 2019, 12:06 PM
This revision was automatically updated to reflect the committed changes.