Differential D2011

test_from_disk.py: avoid shadowing base classes in tests
ClosedPublic
Actions

Authored by zack on Sep 19 2019, 5:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDG41af03e8c8df: test_from_disk.py: avoid shadowing base classes in tests

Summary

reusing the same names is (even more) confusing

Diff Detail

Repository

rDLDG Git loader

Branch

bug/test-loader-redef

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7867
Build 11322: tox-on-jenkins	Jenkins
Build 11321: arc lint + arc unit

Event Timeline

zack created this revision.Sep 19 2019, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 19 2019, 5:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/98/ for more details.

Harbormaster completed remote builds in B7867: Diff 6758.Sep 19 2019, 5:56 PM

ardumont accepted this revision.Sep 19 2019, 9:22 PM

This revision is now accepted and ready to land.Sep 19 2019, 9:22 PM

Closed by commit rDLDG41af03e8c8df: test_from_disk.py: avoid shadowing base classes in tests (authored by zack). · Explain WhySep 19 2019, 10:10 PM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDLDG41af03e8c8df: test_from_disk.py: avoid shadowing base classes in tests.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

tests/

test_from_disk.py

9 lines

Diff 6758

View Options

swh/loader/git/tests/test_from_disk.py

test_from_disk.py: avoid shadowing base classes in testsClosedPublicActions