Differential D2008

Github lister: Prevent erroneous scheduler tasks disabling
ClosedPublic
Actions

Authored by anlambert on Sep 19 2019, 2:26 PM.

Details

Reviewers

ardumont
olasd

Group Reviewers

Reviewers

Commits

rDLS04d8fdf8df45: github/lister: Prevent erroneous scheduler tasks disabling

Summary

This fixes the tasks disabling issue of the Github lister in a same way as for the Phabricator one (see D1990).

Related T2014

Test Plan

Test implemented in D1990 has been moved in base testing class to avoid duplicating it.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 19 2019, 2:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/372/ for more details.

Harbormaster completed remote builds in B7861: Diff 6752.Sep 19 2019, 2:29 PM

Update: Code simplification

olasd accepted this revision.Sep 19 2019, 2:34 PM

This revision is now accepted and ready to land.Sep 19 2019, 2:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/373/ for more details.

ardumont accepted this revision.Sep 19 2019, 2:34 PM

Harbormaster completed remote builds in B7862: Diff 6753.Sep 19 2019, 2:34 PM

Closed by commit rDLS04d8fdf8df45: github/lister: Prevent erroneous scheduler tasks disabling (authored by anlambert). · Explain WhySep 19 2019, 2:36 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS04d8fdf8df45: github/lister: Prevent erroneous scheduler tasks disabling.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

tests/

test_lister.py

26 lines

github/

lister.py

11 lines

tests/

	api_first_response.json
	api_response.json

1600 lines

api_next_response.json

6702 lines

api_response.json

test_gh_lister.py

16 lines

phabricator/

tests/

test_lister.py

21 lines

Diff 6754

View Options

swh/lister/core/tests/test_lister.py

View Options

swh/lister/github/lister.py

View Options

swh/lister/github/tests/api_first_response.json

View Options

swh/lister/github/tests/api_next_response.json

View Options

swh/lister/github/tests/api_response.json

View Options

swh/lister/github/tests/test_gh_lister.py

View Options

swh/lister/phabricator/tests/test_lister.py

Github lister: Prevent erroneous scheduler tasks disablingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6754

swh/lister/core/tests/test_lister.py

swh/lister/github/lister.py

swh/lister/github/tests/api_first_response.json

swh/lister/github/tests/api_next_response.json

swh/lister/github/tests/api_response.json

swh/lister/github/tests/test_gh_lister.py

swh/lister/phabricator/tests/test_lister.py

Github lister: Prevent erroneous scheduler tasks disabling
ClosedPublic
Actions

Revision Contents
Changeset List