Page MenuHomeSoftware Heritage
Differential D191

vault cookers: move repeated functions to base class
ClosedPublic
Actions

Authored by seirl on Mar 13 2017, 3:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC20556dc575bd: vault cookers: move repeated functions to base class
R65:20556dc575bd: vault cookers: move repeated functions to base class
rDSTO20556dc575bd: vault cookers: move repeated functions to base class

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Mar 13 2017, 3:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 13 2017, 3:43 PM
Harbormaster completed remote builds in B762: Diff 595.Mar 13 2017, 3:43 PM
ardumont edited edge metadata.Mar 13 2017, 4:08 PM

A nitpick, can you please change the method's name.
Other than that, it's ok.

swh/storage/vault/cookers/base.py
54

prepare_bundle seems quite nicer.

seirl updated this revision to Diff 597.Mar 13 2017, 4:33 PM

prepare_bundle

Harbormaster completed remote builds in B765: Diff 597.Mar 13 2017, 4:33 PM
ardumont accepted this revision.Mar 13 2017, 4:35 PM
This revision is now accepted and ready to land.Mar 13 2017, 4:35 PM
seirl updated this revision to Diff 598.Mar 13 2017, 4:37 PM

rebase

Closed by commit rDSTO20556dc575bd: vault cookers: move repeated functions to base class (authored by seirl). · Explain WhyMar 13 2017, 4:37 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B766: Diff 598.Mar 13 2017, 4:37 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
vault/
cookers/
23 lines
19 lines
17 lines

Diff 599

View Options

swh/storage/vault/cookers/base.py

Loading...
View Options

swh/storage/vault/cookers/directory.py

Loading...
View Options

swh/storage/vault/cookers/revision_flat.py

Loading...
About · Developer information · Legal