Page MenuHomeSoftware Heritage
Differential D187

vault: generic cache to allow multiple cooker types and formats
ClosedPublic
Actions

Authored by seirl on Mar 6 2017, 1:44 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSTOCedd4d837969f: vault: generic cache to allow multiple cooker types and formats
R65:edd4d837969f: vault: generic cache to allow multiple cooker types and formats
rDSTOedd4d837969f: vault: generic cache to allow multiple cooker types and formats

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Mar 6 2017, 1:44 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 6 2017, 1:44 PM
seirl updated this revision to Diff 581.Mar 6 2017, 1:58 PM

fix pep8

olasd accepted this revision.Mar 9 2017, 1:06 PM
olasd added a subscriber: olasd.

Looks fine to me. Just one tidbit inlined for your consideration.

swh/storage/vault/api/server.py
40–41

use re.escape to make that safer

This revision is now accepted and ready to land.Mar 9 2017, 1:06 PM
seirl updated this revision to Diff 582.Mar 9 2017, 1:58 PM

rebase

Harbormaster completed remote builds in B746: Diff 582.Mar 9 2017, 1:58 PM
seirl updated this revision to Diff 583.Mar 9 2017, 2:02 PM

add re.escape()

Harbormaster completed remote builds in B747: Diff 583.Mar 9 2017, 2:02 PM
seirl marked an inline comment as done.Mar 9 2017, 2:03 PM
Closed by commit rDSTOedd4d837969f: vault: generic cache to allow multiple cooker types and formats (authored by seirl). · Explain WhyMar 9 2017, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
vault/
api/
24 lines
8 lines
27 lines
40 lines
40 lines

Diff 584

View Options

swh/storage/vault/api/client.py

Loading...
View Options

swh/storage/vault/api/cooking_tasks.py

Loading...
View Options

swh/storage/vault/api/server.py

Loading...
View Options

swh/storage/vault/cache.py

Loading...
View Options

swh/storage/vault/cooker.py

Loading...
About · Developer information · Legal