Differential D187

vault: generic cache to allow multiple cooker types and formats
ClosedPublic
Actions

Authored by seirl on Mar 6 2017, 1:44 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOCedd4d837969f: vault: generic cache to allow multiple cooker types and formats
R65:edd4d837969f: vault: generic cache to allow multiple cooker types and formats
rDSTOedd4d837969f: vault: generic cache to allow multiple cooker types and formats

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 747
Build 1001: Software Heritage Python tests
Build 1000: arc lint + arc unit

Event Timeline

seirl created this revision.Mar 6 2017, 1:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 6 2017, 1:44 PM

fix pep8

Looks fine to me. Just one tidbit inlined for your consideration.

swh/storage/vault/api/server.py
40–41	use re.escape to make that safer

This revision is now accepted and ready to land.Mar 9 2017, 1:06 PM

rebase

Harbormaster completed remote builds in B746: Diff 582.Mar 9 2017, 1:58 PM

add re.escape()

Harbormaster completed remote builds in B747: Diff 583.Mar 9 2017, 2:02 PM

seirl marked an inline comment as done.Mar 9 2017, 2:03 PM

Closed by commit rDSTOedd4d837969f: vault: generic cache to allow multiple cooker types and formats (authored by seirl). · Explain WhyMar 9 2017, 2:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

vault/

api/

24 lines

cooking_tasks.py

8 lines

27 lines

40 lines

40 lines

Diff 583

swh/storage/vault/api/client.py

Loading...

swh/storage/vault/api/cooking_tasks.py

Loading...

swh/storage/vault/api/server.py

Loading...

swh/storage/vault/cache.py

Loading...

swh/storage/vault/cooker.py

Loading...