Differential D1868

client: tests: add longer delay for server startup
ClosedPublic
Actions

Authored by haltode on Aug 19 2019, 4:03 PM.

Tags

None

Subscribers

None

Details

Reviewers

zack
seirl

Commits

rDGRPH7705d1c8b8cc: client: tests: add longer delay for server startup

Summary

Unit tests were *sometimes* failing depending on the server startup
time.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Aug 19 2019, 4:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/20/ for more details.

Harbormaster completed remote builds in B7304: Diff 6268.Aug 19 2019, 4:16 PM

zack added inline comments.Aug 19 2019, 5:41 PM

swh/graph/tests/test_api_client.py
36–44	Doing this stuff by hand makes me sad, kinda. We already depend on retrying elsewhere in swh, which makes doing this kind of stuff much nicer/readable. Don't you want to use that instead? (If you insist enough, I can approve this as is, but please give it a thought :-))

zack accepted this revision.Aug 20 2019, 12:30 PM

This revision is now accepted and ready to land.Aug 20 2019, 12:30 PM

Rebasing on master.

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/21/ for more details.

Harbormaster completed remote builds in B7365: Diff 6328.Aug 21 2019, 9:21 PM

Closed by commit rDGRPH7705d1c8b8cc: client: tests: add longer delay for server startup (authored by haltode). · Explain WhyAug 21 2019, 9:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

graph/

tests/

test_api_client.py

15 lines

Diff 6329

swh/graph/tests/test_api_client.py

Loading...