Page MenuHomeSoftware Heritage
Differential D1866

client: tests add missing 'meta' information
ClosedPublic
Actions

Authored by haltode on Aug 19 2019, 3:21 PM.

Details

Reviewers
zack
seirl
Commits
rDGRPHb1fdd018fd5a: client: tests add missing 'meta' information

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Aug 19 2019, 3:21 PM
swh-public-ci added a comment.Aug 19 2019, 3:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/17/ for more details.

Harbormaster completed remote builds in B7299: Diff 6263.Aug 19 2019, 3:23 PM
haltode updated this revision to Diff 6264.Aug 19 2019, 3:25 PM

Rename assert_endpoint_result to assert_endpoint_output.

swh-public-ci added a comment.Aug 19 2019, 3:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/18/ for more details.

Harbormaster completed remote builds in B7300: Diff 6264.Aug 19 2019, 3:27 PM
zack accepted this revision.Aug 19 2019, 3:36 PM

The "Build is green" review.

This revision is now accepted and ready to land.Aug 19 2019, 3:36 PM
Closed by commit rDGRPHb1fdd018fd5a: client: tests add missing 'meta' information (authored by haltode). · Explain WhyAug 19 2019, 3:37 PM
This revision was automatically updated to reflect the committed changes.
olasd added a subscriber: olasd.Aug 19 2019, 3:39 PM

I'd use self.assert_endpoint_result instead of ClassName.assert_endpoint_result but apart from that the refactoring looks sane to me.

Revision Contents
Changeset List

PathSize
swh/
graph/
tests/
126 lines

Diff 6265

View Options

swh/graph/tests/test_api_client.py

Loading...
About · Developer information · Legal