Differential D1863

Add a get_hash helper method to Content.
ClosedPublic
Actions

Authored by vlorentz on Aug 19 2019, 2:35 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDMOD01a5d4cea166: Add a get_hash helper method to Content.

Summary

Code manipulating a Content object may want to access a hash
of configurable name; this method allows it to do that
without using getattr directly.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 19 2019, 2:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2019, 2:35 PM

Harbormaster failed remote builds in B7295: Diff 6258!Aug 19 2019, 2:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/105/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/105/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/106/console

vlorentz added a parent revision: D1861: Add optional 'ctime' field to Content..Aug 19 2019, 2:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/107/ for more details.

Harbormaster completed remote builds in B7295: Diff 6258.Aug 19 2019, 2:41 PM

vlorentz mentioned this in D1865: Make content_add validate its input using swh-model..Aug 19 2019, 3:06 PM

olasd accepted this revision.Aug 20 2019, 11:21 AM

This revision is now accepted and ready to land.Aug 20 2019, 11:21 AM

vlorentz planned changes to this revision.Aug 20 2019, 11:25 AM

rebase
add test

This revision is now accepted and ready to land.Aug 20 2019, 11:38 AM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/109/ for more details.

Harbormaster completed remote builds in B7325: Diff 6289.Aug 20 2019, 11:39 AM

Closed by commit rDMOD01a5d4cea166: Add a get_hash helper method to Content. (authored by vlorentz). · Explain WhyAug 20 2019, 11:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

model/

model.py

6 lines

tests/

test_model.py

9 lines

Diff 6291

View Options

swh/model/model.py