Page MenuHomeSoftware Heritage

Don't set $DJANGO_SETTINGS_MODULE in manage.py
ClosedPublic

Authored by vlorentz on Aug 13 2019, 3:56 PM.

Details

Summary

Unlike what the doc says, it overrides --settings.

Required by D1840

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 13 2019, 3:56 PM
vlorentz edited the summary of this revision. (Show Details)Aug 13 2019, 4:00 PM
olasd requested changes to this revision.Aug 19 2019, 2:00 PM
olasd added a subscriber: olasd.

Doesn't this need a change in tox.ini to pull the proper DJANGO_SETTINGS_MODULE?

Makefile.local
27–28

Missing space

This revision now requires changes to proceed.Aug 19 2019, 2:00 PM

Doesn't this need a change in tox.ini to pull the proper DJANGO_SETTINGS_MODULE?

tox.ini invokes pytest, not manage.py, so it does not run this code.

Makefile.local
27–28

Good catch

vlorentz updated this revision to Diff 6252.Aug 19 2019, 2:07 PM

fix typo

vlorentz marked an inline comment as done.Aug 19 2019, 2:07 PM
olasd added a comment.Aug 19 2019, 2:07 PM

Nevermind my last question, DJANGO_SETTINGS_MODULE is properly set in pytest.ini (and I'm apparently blind)

olasd accepted this revision.Aug 19 2019, 2:07 PM
This revision is now accepted and ready to land.Aug 19 2019, 2:07 PM
This revision was landed with ongoing or failed builds.Aug 19 2019, 2:08 PM
This revision was automatically updated to reflect the committed changes.