Differential D1848

Don't set $DJANGO_SETTINGS_MODULE in manage.py
ClosedPublic
Actions

Authored by vlorentz on Aug 13 2019, 3:56 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDWAPPS033e97557be1: Don't set $DJANGO_SETTINGS_MODULE in manage.py

Summary

Unlike what the doc says, it overrides --settings.

Required by D1840

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 13 2019, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 13 2019, 3:56 PM

vlorentz edited the summary of this revision. (Show Details)Aug 13 2019, 4:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/663/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/260/ for more details.

Harbormaster completed remote builds in B7247: Diff 6215.Aug 13 2019, 4:09 PM

vlorentz added a child revision: D1840: cypress: Test Admin authentication.Aug 19 2019, 12:22 PM

Doesn't this need a change in tox.ini to pull the proper DJANGO_SETTINGS_MODULE?

Makefile.local
27–28	Missing space

This revision now requires changes to proceed.Aug 19 2019, 2:00 PM

Doesn't this need a change in tox.ini to pull the proper DJANGO_SETTINGS_MODULE?

tox.ini invokes pytest, not manage.py, so it does not run this code.

Makefile.local
27–28	Good catch

fix typo

vlorentz marked an inline comment as done.Aug 19 2019, 2:07 PM

Nevermind my last question, DJANGO_SETTINGS_MODULE is properly set in pytest.ini (and I'm apparently blind)

olasd accepted this revision.Aug 19 2019, 2:07 PM

This revision is now accepted and ready to land.Aug 19 2019, 2:07 PM

rebase

This revision was landed with ongoing or failed builds.Aug 19 2019, 2:08 PM

Closed by commit rDWAPPS033e97557be1: Don't set $DJANGO_SETTINGS_MODULE in manage.py (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/671/ for more details.

Harbormaster failed remote builds in B7290: Diff 6253!Aug 19 2019, 2:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/672/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/672/console

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/269/ for more details.

Harbormaster completed remote builds in B7289: Diff 6252.Aug 19 2019, 2:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/270/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/270/console

Revision Contents
Changeset List

			Path	Packages
M			Makefile.local (10 lines)
M			swh/web/manage.py (7 lines)

Diff 6254

Makefile.local

Loading...

swh/web/manage.py

Loading...