Page MenuHomeSoftware Heritage
Differential D1837

cypress: Add tests for the vault features
ClosedPublic
Actions

Authored by kalpitk on Aug 9 2019, 3:15 PM.

Details

Reviewers
ardumont
anlambert
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSd0369f043f49: cypress: vault.spec.js: Add tests
rDWAPPS27d7cc8deb70: cypress: Add tests for the vault features
Summary

That diff is a first draft of implementing end to end tests for the vault features
of the Software Heritage web application.

Some tests remain to be written and some code factorization should also be performed
to easily implement the revision cooking test.

I'm forwarding future work on this to @kalpitk as I will be in holidays during the
next two weeks but GSoC coding period is still active.

Related T1768

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 9 2019, 3:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 9 2019, 3:15 PM
swh-public-ci added a comment.Aug 9 2019, 3:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/655/ for more details.

swh-public-ci added a comment.Aug 9 2019, 3:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/251/ for more details.

Harbormaster completed remote builds in B7213: Diff 6183.Aug 9 2019, 3:28 PM
anlambert mentioned this in D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs.Aug 9 2019, 4:39 PM
ardumont accepted this revision.Aug 9 2019, 5:01 PM
ardumont added a subscriber: ardumont.

sounds nice

not sure i understand all the implications though ;)

This revision is now accepted and ready to land.Aug 9 2019, 5:01 PM
anlambert added a comment.Aug 9 2019, 5:05 PM

@ardumont, you can check the effect of that test through the cypress UI.

Execute $ make test-frontend-ui in the root folder of swh-web, a GUI fronted for cypress will be launched.

Then select any test in the displayed list, it will be executed in a Chromium based browser (using Electron as a default fallback)
and you can see the details of each test steps.

This make me think that I need to update the README to explain how to run the tests ;-)

kalpitk commandeered this revision.Aug 12 2019, 1:27 PM
kalpitk added a reviewer: anlambert.
kalpitk updated this revision to Diff 6217.Aug 13 2019, 4:18 PM
  • Add assertions to directory vault cooking
swh-public-ci added a comment.Aug 13 2019, 4:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/664/ for more details.

swh-public-ci added a comment.Aug 13 2019, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/261/ for more details.

Harbormaster completed remote builds in B7249: Diff 6217.Aug 13 2019, 4:30 PM
kalpitk updated this revision to Diff 6233.Aug 14 2019, 9:52 PM
  • Add tests
kalpitk updated this revision to Diff 6234.Aug 14 2019, 9:56 PM
  • fix typo
swh-public-ci added a comment.Aug 14 2019, 9:59 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/665/ for more details.

swh-public-ci added a comment.Aug 14 2019, 10:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/666/ for more details.

swh-public-ci added a comment.Aug 14 2019, 10:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/262/ for more details.

Harbormaster completed remote builds in B7266: Diff 6233.Aug 14 2019, 10:09 PM
swh-public-ci added a comment.Aug 14 2019, 10:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/263/ for more details.

Harbormaster completed remote builds in B7267: Diff 6234.Aug 14 2019, 10:20 PM
kalpitk updated this revision to Diff 6237.Aug 15 2019, 7:18 PM
  • Add tests for localStorage
swh-public-ci added a comment.Aug 15 2019, 7:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/667/ for more details.

swh-public-ci added a comment.Aug 15 2019, 7:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/264/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/264/console

Harbormaster failed remote builds in B7271: Diff 6237!Aug 15 2019, 7:30 PM
kalpitk added a comment.Aug 16 2019, 3:37 PM

Cypress test fails because of origin-search.spec.js(fails sometimes). Will try correcting in another diff

kalpitk updated this revision to Diff 6239.Aug 16 2019, 3:49 PM

retrigger build

swh-public-ci added a comment.Aug 16 2019, 3:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/668/ for more details.

swh-public-ci added a comment.Aug 16 2019, 4:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/265/ for more details.

Harbormaster completed remote builds in B7274: Diff 6239.Aug 16 2019, 4:02 PM
kalpitk mentioned this in D1858: cypress: origin-search.spec: Add tests.Aug 19 2019, 9:28 AM
vlorentz requested changes to this revision.Aug 19 2019, 11:28 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
cypress/integration/vault.spec.js
16–40

These should have a comment explaining they are used to mock an API endpoint (and the name of the endpoint)

76

Rename this to sha1 or just id. object_id has a different meaning in other parts of SWH (it's an integer).

151–152

remove "indicating"

cypress/support/index.js
71

it should be named origin.revisions then.

This revision now requires changes to proceed.Aug 19 2019, 11:28 AM
vlorentz added a comment.Aug 19 2019, 11:29 AM

And you'll need to squash your commits (but not with @anlambert's initial commit, to preserve ownership information)

kalpitk added inline comments.Aug 19 2019, 2:11 PM
cypress/integration/vault.spec.js
76

Vault item object is as it is stored in local storage.

vlorentz added inline comments.Aug 19 2019, 2:36 PM
cypress/integration/vault.spec.js
76

Meh. Ok then.

kalpitk updated this revision to Diff 6272.Aug 19 2019, 4:22 PM
  • rebase
  • changes acc to requested changes
  • commit msgs updated
swh-public-ci added a comment.Aug 19 2019, 4:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/676/ for more details.

swh-public-ci added a comment.Aug 19 2019, 4:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/275/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/275/console

Harbormaster failed remote builds in B7308: Diff 6272!Aug 19 2019, 4:56 PM
kalpitk updated this revision to Diff 6278.Aug 19 2019, 4:56 PM
  • revision[0] -> revisions[0]
vlorentz accepted this revision.Aug 19 2019, 4:57 PM
This revision is now accepted and ready to land.Aug 19 2019, 4:57 PM
vlorentz requested changes to this revision.Aug 19 2019, 4:58 PM

Let's wait for the build result first

This revision now requires changes to proceed.Aug 19 2019, 4:58 PM
swh-public-ci added a comment.Aug 19 2019, 5:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/677/ for more details.

swh-public-ci added a comment.Aug 19 2019, 5:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/277/ for more details.

Harbormaster completed remote builds in B7314: Diff 6278.Aug 19 2019, 5:24 PM
vlorentz accepted this revision.Aug 20 2019, 10:54 AM
This revision is now accepted and ready to land.Aug 20 2019, 10:54 AM
kalpitk updated this revision to Diff 6288.Aug 20 2019, 11:24 AM
  • rebase
swh-public-ci added a comment.Aug 20 2019, 11:33 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/680/ for more details.

swh-public-ci added a comment.Aug 20 2019, 11:50 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/280/ for more details.

Harbormaster completed remote builds in B7324: Diff 6288.Aug 20 2019, 11:50 AM
Closed by commit rDWAPPS27d7cc8deb70: cypress: Add tests for the vault features (authored by anlambert, committed by kalpitk). · Explain WhyAug 20 2019, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6292

View Options

cypress.json

Loading...
View Options

cypress/fixtures/1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz

Loading...
View Options

cypress/fixtures/cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz

Loading...
View Options

cypress/integration/vault.spec.js

Loading...
View Options

cypress/support/index.js

Loading...
About · Developer information · Legal