Differential D1825

Remove concurrency and error-handling from the content replayer.
ClosedPublic
Actions

Authored by vlorentz on Aug 7 2019, 1:13 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNL17a0c3412e8d: Remove concurrency and error-handling from the content replayer.

Summary

ThreadPoolExecutor hides errors, so failures to copy an object wouldn't
prevent committing to Kafka.

Also, libcloud (or maybe only its S3 backend) does not work well with
threads.

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

content-replay-single-thread

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7180
Build 10133: tox-on-jenkins	Jenkins
Build 10132: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 7 2019, 1:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 7 2019, 1:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/216/ for more details.

Harbormaster completed remote builds in B7180: Diff 6152.Aug 7 2019, 1:17 PM

ardumont accepted this revision.Aug 7 2019, 2:14 PM

This revision is now accepted and ready to land.Aug 7 2019, 2:14 PM

Closed by commit rDJNL17a0c3412e8d: Remove concurrency and error-handling from the content replayer. (authored by vlorentz). · Explain WhyAug 7 2019, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

cli.py

6 lines

replay.py

46 lines

Diff 6152

View Options

swh/journal/cli.py