Page MenuHomeSoftware Heritage

Remove concurrency and error-handling from the content replayer.
ClosedPublic

Authored by vlorentz on Aug 7 2019, 1:13 PM.

Details

Summary

ThreadPoolExecutor hides errors, so failures to copy an object wouldn't
prevent committing to Kafka.

Also, libcloud (or maybe only its S3 backend) does not work well with
threads.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 7 2019, 1:13 PM
ardumont accepted this revision.Aug 7 2019, 2:14 PM
This revision is now accepted and ready to land.Aug 7 2019, 2:14 PM
This revision was automatically updated to reflect the committed changes.