Page MenuHomeSoftware Heritage

staging: Modularize node creation
ClosedPublic

Authored by ardumont on Aug 2 2019, 7:53 PM.

Details

Summary

This allows to refactor the redundancy between nodes.

I kept out of the refactor loop the gateway for now because it's diverging a bit much
with other nodes (I'm not fluent enough yet with terraform dsl to understand how i can make it comply)

In the next commit (D1807), we'll see how to use that refactoring to declare a new node
without too many duplication.

@douardda might be interested by it since we talked about it ;)

Test Plan
terraform init
terraform plan

Diff Detail

Repository
rSPRE sysadm-provisioning
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 2 2019, 7:53 PM
ardumont updated this revision to Diff 6090.Aug 2 2019, 7:56 PM

Update to remove the db0 creation (it's for the next commit)

ardumont edited the summary of this revision. (Show Details)
ardumont edited the summary of this revision. (Show Details)Aug 2 2019, 8:09 PM
ardumont added a subscriber: douardda.
ardumont edited the summary of this revision. (Show Details)Aug 2 2019, 9:18 PM
ftigeot accepted this revision.Aug 2 2019, 10:09 PM

A bit too big to understand quickly but no real choice here.
Looks good.

This revision is now accepted and ready to land.Aug 2 2019, 10:09 PM

A bit too big to understand quickly but no real choice here.

Yes, the variables i crafted to avoid repetition are a bit verbose and unfortunately duplicated for now (i am currently trying to find a way to avoid that).

Looks good.

For information, the terraform apply does not want to do anything.
Which means that nothing changes between the old way of doing it and the way define in the diff.
So it should be good ;)

Cheers,

This revision was automatically updated to reflect the committed changes.