swh_hostname: Deal with all swh domains
ClosedPublic
Actions

Authored by ardumont on Jul 26 2019, 5:47 PM.

Details

Reviewers

olasd
ftigeot
douardda

Group Reviewers

Reviewers

Commits

rSPSITEf5d0ddfd7c75: swh_hostname: Deal with all swh domains

Summary

Related T1876

Test Plan

bin/octocatalog tryout on multiple machines (uffizi, worker01, saatchi, getty)

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 26 2019, 5:47 PM

Harbormaster completed remote builds in B7047: Diff 6007.Jul 26 2019, 5:47 PM

ardumont edited the test plan for this revision. (Show Details)Jul 27 2019, 4:29 PM

LGTM but I'm no ruby guy

This revision is now accepted and ready to land.Jul 29 2019, 1:48 PM

Plug to production branch

Harbormaster completed remote builds in B7062: Diff 6023.Jul 29 2019, 2:39 PM

Closed by commit rSPSITEf5d0ddfd7c75: swh_hostname: Deal with all swh domains (authored by ardumont). · Explain WhyJul 29 2019, 2:40 PM

This revision was automatically updated to reflect the committed changes.

ardumont added inline comments.Jul 29 2019, 2:49 PM

site-modules/profile/lib/facter/swh_hostname.rb
4	probably missing a ","

ardumont mentioned this in rSPSITEe2742a2125d8: swh_hostname: Fix typo in domain_names list.Jul 29 2019, 2:56 PM

ardumont added inline comments.Jul 30 2019, 5:36 PM

site-modules/profile/lib/facter/swh_hostname.rb
4	yes, fixed in rSPSITEe2742a2125d8d98960c14f8bdea03839b117a84f
19	That does not what i expected. This needs to be fixed (working on it)

ardumont mentioned this in rSPSITE877b4ed3a9b9: swh_hostname: Fix fqdn computation.Jul 30 2019, 5:58 PM

Revision Contents
Changeset List

Path

Size

site-modules/

profile/

lib/

facter/

swh_hostname.rb

23 lines

Diff 6024

View Options

site-modules/profile/lib/facter/swh_hostname.rb

swh_hostname: Deal with all swh domainsClosedPublicActions