Page MenuHomeSoftware Heritage

swh_hostname: Deal with all swh domains
ClosedPublic

Authored by ardumont on Jul 26 2019, 5:47 PM.

Details

Summary

Related T1876

Test Plan

bin/octocatalog tryout on multiple machines (uffizi, worker01, saatchi, getty)

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 26 2019, 5:47 PM
ardumont edited the test plan for this revision. (Show Details)Jul 27 2019, 4:29 PM
douardda accepted this revision.Jul 29 2019, 1:48 PM
douardda added a subscriber: douardda.

LGTM but I'm no ruby guy

This revision is now accepted and ready to land.Jul 29 2019, 1:48 PM
ardumont updated this revision to Diff 6023.Jul 29 2019, 2:39 PM
ardumont edited the test plan for this revision. (Show Details)

Plug to production branch

This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Jul 29 2019, 2:49 PM
site-modules/profile/lib/facter/swh_hostname.rb
5

probably missing a ","

ardumont added inline comments.Jul 30 2019, 5:36 PM
site-modules/profile/lib/facter/swh_hostname.rb
5
19

That does not what i expected.
This needs to be fixed (working on it)