Page MenuHomeSoftware Heritage
Differential D1771

Add option --exclude-sha1-file to content-replay.
ClosedPublic
Actions

Authored by vlorentz on Jul 25 2019, 3:10 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDJNL3183a77771ec: Add option --exclude-sha1-file to content-replay.
Summary

Depends on D1770.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 25 2019, 3:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 25 2019, 3:10 PM
swh-public-ci added a comment.Jul 25 2019, 3:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/200/ for more details.

Harbormaster completed remote builds in B7024: Diff 5983.Jul 25 2019, 3:13 PM
douardda accepted this revision.Jul 29 2019, 2:07 PM
douardda added a subscriber: douardda.

Thanks for this stack. Note my small comment about using the hardcoded value 20 in there. These values should come somehow from swh.model I guess...

swh/journal/cli.py
195

Bit odd to read here the constant '20' while SHA1_SIZE is defined in replay.py

This revision is now accepted and ready to land.Jul 29 2019, 2:07 PM
vlorentz mentioned this in D1816: Add a SHA1_SIZE constant for use by other packages..Aug 5 2019, 10:56 AM
vlorentz updated this revision to Diff 6138.Aug 6 2019, 2:37 PM

Use SHA1_SIZE constant from swh.model.

swh-public-ci added a comment.Aug 6 2019, 2:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/210/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/210/console

Harbormaster failed remote builds in B7167: Diff 6138!Aug 6 2019, 2:39 PM
vlorentz updated this revision to Diff 6139.Aug 6 2019, 2:46 PM

Fix import path

swh-public-ci added a comment.Aug 6 2019, 2:46 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/211/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/211/console

swh-public-ci added a comment.Aug 6 2019, 2:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/212/ for more details.

Harbormaster completed remote builds in B7168: Diff 6139.Aug 6 2019, 2:49 PM
Closed by commit rDJNL3183a77771ec: Add option --exclude-sha1-file to content-replay. (authored by vlorentz). · Explain WhyAug 6 2019, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
swh/
journal/
33 lines
75 lines
tests/
38 lines

Diff 6140

View Options

requirements-swh.txt

Loading...
View Options

swh/journal/cli.py

Loading...
View Options

swh/journal/replay.py

Loading...
View Options

swh/journal/tests/test_cli.py

Loading...
About · Developer information · Legal