Page MenuHomeSoftware Heritage
Differential D1707

Improve image and pdf contents rendering
ClosedPublic
Actions

Authored by kalpitk on Jul 10 2019, 12:01 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPSa4816b7bb313: Improve pdf, image rendering
Summary

Related T1900
set max width of pdf, img to that of parent container

Diff Detail

Repository
rDWAPPS Web applications
Branch
impRender
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6754
Build 9441: tox-on-jenkinsJenkins
Build 9440: arc lint + arc unit

Event Timeline

kalpitk created this revision.Jul 10 2019, 12:01 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2019, 12:01 PM
swh-public-ci added a comment.Jul 10 2019, 12:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/589/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/589/console

Harbormaster failed remote builds in B6754: Diff 5732!Jul 10 2019, 12:04 PM
kalpitk updated this revision to Diff 5738.Jul 10 2019, 12:51 PM

Add css for img max-width

swh-public-ci added a comment.Jul 10 2019, 12:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/592/ for more details.

Harbormaster completed remote builds in B6760: Diff 5738.Jul 10 2019, 12:54 PM
kalpitk retitled this revision from [WIP] Improve image and pdf contents rendering to Improve image and pdf contents rendering.Jul 10 2019, 12:58 PM
kalpitk updated this revision to Diff 5744.Jul 10 2019, 2:03 PM

add max-width to svg in readme

swh-public-ci added a comment.Jul 10 2019, 2:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/599/ for more details.

Harbormaster completed remote builds in B6766: Diff 5744.Jul 10 2019, 2:10 PM
anlambert accepted this revision.Jul 10 2019, 2:38 PM
anlambert added a subscriber: anlambert.

Looks good, thanks !

swh/web/assets/src/bundles/browse/content.css
20 ↗(On Diff #5744)

You should also add a rule for svgelements here

This revision is now accepted and ready to land.Jul 10 2019, 2:38 PM
kalpitk added inline comments.Jul 10 2019, 5:20 PM
swh/web/assets/src/bundles/browse/content.css
20 ↗(On Diff #5744)

Svg files are rendered inside img tag in swh-content

anlambert added inline comments.Jul 10 2019, 5:22 PM
swh/web/assets/src/bundles/browse/content.css
20 ↗(On Diff #5744)

Maybe but this could change in the future so I will prefer to have the rule set.

kalpitk updated this revision to Diff 5776.Jul 10 2019, 9:26 PM

add max-width for svg in swh-content

swh-public-ci added a comment.Jul 10 2019, 9:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/603/ for more details.

Harbormaster completed remote builds in B6796: Diff 5776.Jul 10 2019, 9:29 PM
kalpitk updated this revision to Diff 5777.Jul 10 2019, 9:30 PM

Rebase with master

swh-public-ci added a comment.Jul 10 2019, 9:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/604/ for more details.

Harbormaster completed remote builds in B6797: Diff 5777.Jul 10 2019, 9:33 PM
Closed by commit rDWAPPSa4816b7bb313: Improve pdf, image rendering (authored by kalpitk). · Explain WhyJul 10 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
webapp/
10 lines
utils/
4 lines
templates/
includes/
2 lines

Diff 5732

View Options

swh/web/assets/src/bundles/webapp/pdf-rendering.js

Loading...
View Options

swh/web/assets/src/utils/showdown.css

Loading...
View Options

swh/web/templates/includes/content-display.html

Loading...
About · Developer information · Legal