Paths

Table of Contentst

Stop using the 'hidden' click option
ClosedPublic
Actions

Authored by ardumont on Jul 2 2019, 7:11 PM.

Details

Reviewers

vlorentz
douardda

Group Reviewers

Reviewers

Commits

rDJNL687d06efa937: Stop using the 'hidden' click option

Summary

This is not supported in debian 9 yet.

Indexer still fails to build [1]

Related 4689f3c
(which was not exhaustive enough)
Related D1674

[1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DCIDX/job/gbp-buildpackage/59/console

Test Plan

tox
Checking exhaustiveness

grep -r "hidden=" * renders nothing after that

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 2 2019, 7:11 PM

ardumont edited the summary of this revision. (Show Details)Jul 2 2019, 7:13 PM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a project: Journal.

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/174/ for more details.

Harbormaster completed remote builds in B6636: Diff 5628.Jul 2 2019, 7:15 PM

douardda accepted this revision.Jul 3 2019, 10:04 AM

This revision is now accepted and ready to land.Jul 3 2019, 10:04 AM

Maybe modify help messages the way vlorentz did in D1674

Update help message to add deprecated notice (as reasonably proposed)

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/176/ for more details.

Harbormaster completed remote builds in B6640: Diff 5632.Jul 3 2019, 10:23 AM

Closed by commit rDJNL687d06efa937: Stop using the 'hidden' click option (authored by ardumont). · Explain WhyJul 3 2019, 10:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

cli.py

12 lines

Diff 5633

View Options

Stop using the 'hidden' click optionClosedPublicActions