Page MenuHomeSoftware Heritage
Differential D1663

Add a 'reset' endpoint to the in-mem storage.
ClosedPublic
Actions

Authored by vlorentz on Jun 28 2019, 8:34 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDSTOC37396a51dc12: Add a 'reset' endpoint to the in-mem storage.
rDSTO37396a51dc12: Add a 'reset' endpoint to the in-mem storage.
Summary

It will be used for API client/server property tests,
because they need to remotely reset the state and cannot
create a new storage.

Diff Detail

Repository
rDSTO Storage manager
Branch
inmem-reset
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6606
Build 9220: tox-on-jenkinsJenkins
Build 9219: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 28 2019, 8:34 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2019, 8:34 PM
swh-public-ci added a comment.Jun 28 2019, 8:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/513/ for more details.

Harbormaster completed remote builds in B6575: Diff 5568.Jun 28 2019, 8:48 PM
vlorentz added a child revision: D1664: Merge id/url tests using an arg provided by hypothesis..Jun 28 2019, 8:52 PM
douardda added a subscriber: douardda.Jul 1 2019, 2:02 PM

I may have missed it, but where is this specific endpoint used? I cannot find any usage in following diffs... Why is this "cannot create a new storage" statement true?

vlorentz added a comment.Jul 1 2019, 2:04 PM
In D1663#38472, @douardda wrote:

I may have missed it, but where is this specific endpoint used? I cannot find any usage in following diffs...

D1664, ctrl-f .reset()

Why is this "cannot create a new storage" statement true?

Because the storage does not run in the same process as the tests.

douardda added a comment.Jul 1 2019, 2:11 PM
In D1663#38475, @vlorentz wrote:
In D1663#38472, @douardda wrote:

I may have missed it, but where is this specific endpoint used? I cannot find any usage in following diffs...

D1664, ctrl-f .reset()

I saw this but wasn't sure it was the same exposed reset() function.

Why is this "cannot create a new storage" statement true?

Because the storage does not run in the same process as the tests.

humm ok then.

douardda accepted this revision.Jul 1 2019, 2:12 PM
This revision is now accepted and ready to land.Jul 1 2019, 2:12 PM
vlorentz updated this revision to Diff 5598.Jul 1 2019, 3:50 PM

rebase

This revision was landed with ongoing or failed builds.Jul 1 2019, 3:50 PM
Closed by commit rDSTO37396a51dc12: Add a 'reset' endpoint to the in-mem storage. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B6606: Diff 5598!Jul 1 2019, 4:08 PM
swh-public-ci added a comment.Jul 1 2019, 4:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/525/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/525/console

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
3 lines
6 lines
12 lines

Diff 5598

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
About · Developer information · Legal