Paths

Table of Contentst

Differential D1631

bitbucket: Allow to specify the number of repos per api request
ClosedPublic
Actions

Authored by ardumont on Jun 21 2019, 5:28 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDLS9aa8a6f7ae92: bitbucket: Allow to specify the number of repos per api request

Summary

This is independent but still, it somehow fixes the issue occurring on T1826
(at least for the full lister... which is weird...)

Related T1826

Depends on D1628
Depends on D1629

Test Plan

tox
docker-dev

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6416
Build 8905: tox-on-jenkins	Jenkins
Build 8904: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 21 2019, 5:28 PM

Harbormaster failed remote builds in B6414: Diff 5427!Jun 21 2019, 5:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/219/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/219/console

ardumont edited the summary of this revision. (Show Details)Jun 21 2019, 5:30 PM

ardumont added parent revisions: D1629: bitbucket: Fix full lister with fallback [start, end] if not provided, D1628: Drop SWH prefix in classes everywhere.

olasd accepted this revision.Jun 21 2019, 5:30 PM

olasd added inline comments.

swh/lister/bitbucket/lister.py
30–31	Hmmm the building of query parameters with a template leaves a strong aftertaste.
88–89	there's one level of parentheses too many now

This revision is now accepted and ready to land.Jun 21 2019, 5:30 PM

ardumont added inline comments.Jun 21 2019, 5:32 PM

swh/lister/bitbucket/lister.py
30–31	Yes, it's ugly. I did as in another lister though (gitlab one, i believe it's ugly as well, mind you ;) I could maybe check the `request_params` method override (or something called similarly).
88–89	ack

olasd added inline comments.Jun 21 2019, 5:33 PM

swh/lister/bitbucket/lister.py
30–31	Yeah, I'm not suggesting fixing it in that diff at all, just something that we could improve upon at some point.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/220/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/220/console

Build has FAILED

oh, that's why i did not open it earlier ;)
nice catch jenkins, thanks.

Fix tests

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/221/ for more details.

Harbormaster completed remote builds in B6415: Diff 5428.Jun 21 2019, 5:43 PM

ardumont added inline comments.Jun 21 2019, 5:47 PM

swh/lister/bitbucket/lister.py
30–31	Hmmm the building of query parameters with a template leaves a strong aftertaste. Oh the complete PATH_TEMPLATE stanza, you mean. Right! A priori, down to the core class (the http ones), this uses within `requests` (for http listers at least which is... all?). Thus, we may be able to use those `params` as a dict... Avoiding the need for use to build ourselves the query params... and letting requests do it. (Maybe) But indeed, for later ;)

Fix one level of parentheses too many

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/222/ for more details.

Harbormaster completed remote builds in B6416: Diff 5429.Jun 21 2019, 5:55 PM

Closed by commit rDLS9aa8a6f7ae92: bitbucket: Allow to specify the number of repos per api request (authored by ardumont). · Explain WhyJun 21 2019, 5:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

bitbucket/

19 lines

6 lines

tests/

9 lines

Diff 5429

swh/lister/bitbucket/lister.py

Loading...

swh/lister/bitbucket/tasks.py

Loading...

swh/lister/bitbucket/tests/test_tasks.py

Loading...