Page MenuHomeSoftware Heritage
Differential D1600

Use origin urls instead of origin ids (swh-loader-npm)
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 3:11 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDNPM0952ec7f8771: Use origin urls instead of origin ids.

Diff Detail

Repository
rDLDNPM npm loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 3:11 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 3:11 PM
swh-public-ci added a comment.Jun 18 2019, 3:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/27/console

Harbormaster failed remote builds in B6286: Diff 5305!Jun 18 2019, 3:14 PM
vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 18 2019, 3:15 PM
vlorentz updated this revision to Diff 5310.Jun 18 2019, 3:37 PM

fix commit msg

vlorentz edited the summary of this revision. (Show Details)Jun 18 2019, 3:38 PM
swh-public-ci added a comment.Jun 18 2019, 3:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/28/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/28/console

Harbormaster failed remote builds in B6291: Diff 5310!Jun 18 2019, 3:41 PM
ardumont added a subscriber: ardumont.Jun 19 2019, 9:32 AM

Build is not ok.

Is it possible that the call to the in-memory storage fails because of the missing associated function implementation?
No, i checked, the current last commit is fine though.

Still the build failure points toward what i hinted at:

AttributeError: 'Storage' object has no attribute 'origin_visit_get_latest'
ardumont added a comment.Jun 19 2019, 10:07 AM

Can you please try and fix the build?

Waiting for the build to be green as well before accepting the diff.

TIA

swh-public-ci added a comment.Jun 19 2019, 11:06 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/29/ for more details.

Harbormaster completed remote builds in B6291: Diff 5310.Jun 19 2019, 11:06 AM
vlorentz updated this revision to Diff 5334.Jun 19 2019, 11:07 AM

bump swh-storage version.

swh-public-ci added a comment.Jun 19 2019, 11:10 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDNPM/job/tox/30/ for more details.

Harbormaster completed remote builds in B6316: Diff 5334.Jun 19 2019, 11:10 AM
ardumont accepted this revision.Jun 19 2019, 11:13 AM
This revision is now accepted and ready to land.Jun 19 2019, 11:13 AM
Closed by commit rDLDNPM0952ec7f8771: Use origin urls instead of origin ids. (authored by vlorentz). · Explain WhyJun 19 2019, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
npm/
9 lines

Diff 5335

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/npm/loader.py

Loading...
About · Developer information · Legal