Page MenuHomeSoftware Heritage

Update docker-compose logs command in README
ClosedPublic

Authored by nahimilega on Jun 7 2019, 2:45 PM.

Details

Summary

Updated the docker-compose logs command in README because it was using swh-lister-debian whereas there is no such service
present. Hence chnaged it the the latest service present which is swh-lister

Diff Detail

Repository
rCDFD Dockerfiles for developers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6091
Build 8389: arc lint + arc unit

Event Timeline

nahimilega created this revision.Jun 7 2019, 2:45 PM
vlorentz accepted this revision.Jun 12 2019, 11:09 AM
This revision is now accepted and ready to land.Jun 12 2019, 11:09 AM

I am not able to push this change.

(swh) archit@work-pc:~/swh-environment/swh-docker-dev$ git push
Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Output of git remote -v?

Output of git remote -v?

(swh) archit@work-pc:~/swh-environment/swh-docker-dev$ git remote -v
origin	https://forge.softwareheritage.org/source/swh-docker-dev.git (fetch)
origin	git@forge.softwareheritage.org:/source/swh-docker-dev.git (push)

Output of git remote -v?

(swh) archit@work-pc:~/swh-environment/swh-docker-dev$ git remote -v
origin	https://forge.softwareheritage.org/source/swh-docker-dev.git (fetch)
origin	git@forge.softwareheritage.org:/source/swh-docker-dev.git (push)

Have you setup-ed the following as mentionned in [1]?

git config --global url.git@forge.softwareheritage.org:.pushInsteadOf https://forge.softwareheritage.org

[1] https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator#SSH_key_for_pushes

Have you setup-ed the following as mentionned in [1]?

git config --global url.git@forge.softwareheritage.org:.pushInsteadOf https://forge.softwareheritage.org

[1] https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator#SSH_key_for_pushes

nevermind, it's the current repository's setup (which is marked as staff).
So you currently cannot land stuff yourself, we need to do it.

I'll land this (as i need some tryouts with that tool).

ardumont requested changes to this revision.Jun 17 2019, 5:36 PM

I'll land this (as i need some tryouts with that tool).

mmm, wait!

The point of this documentation snippet here was to demonstrate a docker refusing to start.
And to see what's happening through a docker-compose logs command as a first debugging step.

So if there needs an update (which i doubt), it'd be to rename swh-lister-debian_1 to swh-lister_1...

Granted, swh-lister-debian no longer exists (as it got merged in swh-lister) but meh...
Please either update to rename as mentioned or drop this diff altogether.

Thanks in advance.

This revision now requires changes to proceed.Jun 17 2019, 5:36 PM

The point of this documentation snippet here was to demonstrate a docker refusing to start.
And to see what's happening through a docker-compose logs command as a first debugging step.
So if there needs an update (which i doubt), it'd be to rename swh-lister-debian_1 to swh-lister_1...

I tried

doco logs swh-lister_1

But it didn't work ` ERROR: No such service: swh-lister_1 `

neither did doco logs ` swh-lister-debian `or `swh-lister-debian_1 `

The only command that gave logs were

doco logs swh-lister

Which I changed here in this diff.

Please correct me if am an not able to get what I wanted to communicate.

Which I changed here in this diff.

You did but you did more than just changing the command.
You also changed the output of the log with something that is no longer an error...
I'd keep the error.

So:

  • Keep the command you changed correctly.
  • Revert the logs output change (keep the previous output)
  • Adapt eventually the swh-lister-debian_1 to swh-lister_1 to stay in sync with the commands

Hope this is clearer.

Cheers,

nevermind, it's the current repository's setup (which is marked as staff).
So you currently cannot land stuff yourself, we need to do it.

I fixed the project config to allow pushes.

nahimilega updated this revision to Diff 5332.Jun 19 2019, 10:50 AM

Made changes as advised

ardumont accepted this revision.Jun 19 2019, 10:59 AM
This revision is now accepted and ready to land.Jun 19 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.