Page MenuHomeSoftware Heritage
Differential D1556

Add support for omitting origin type when calling origin_get.
ClosedPublic
Actions

Authored by vlorentz on Jun 6 2019, 4:14 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1731: Intrinsic identifiers for origins
Commits
rDSTOC710e0bfb288b: Add support for omitting origin type when calling origin_get.
rDSTO710e0bfb288b: Add support for omitting origin type when calling origin_get.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 6 2019, 4:14 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 6 2019, 4:14 PM
vlorentz added a task: T1731: Intrinsic identifiers for origins.Jun 6 2019, 4:15 PM
vlorentz updated this revision to Diff 5113.Jun 6 2019, 4:16 PM

add 'create extension' in migration script.

ardumont added a subscriber: ardumont.Jun 6 2019, 4:20 PM
ardumont added inline comments.
sql/upgrades/135.sql
7

135?

9

I think that needs to run as postgres user.
So not sure if that needs to be declared here, maybe in comments instead?

swh-public-ci added a comment.Jun 6 2019, 4:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/452/ for more details.

Harbormaster completed remote builds in B6062: Diff 5112.Jun 6 2019, 4:21 PM
vlorentz updated this revision to Diff 5117.Jun 6 2019, 4:21 PM

fix version number

vlorentz marked an inline comment as done.Jun 6 2019, 4:22 PM
vlorentz added inline comments.
sql/upgrades/135.sql
9

create extension statements are in swh/storage/sql/ same as everything else, so it's consistent to put that in the migration script.

ardumont added inline comments.Jun 6 2019, 4:24 PM
sql/upgrades/135.sql
9

Yes.
My doubt is not about consistency, it's about running when applied during migration.
But meh ;)

ardumont accepted this revision.Jun 6 2019, 4:25 PM
This revision is now accepted and ready to land.Jun 6 2019, 4:25 PM
swh-public-ci added a comment.Jun 6 2019, 4:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/453/ for more details.

Harbormaster completed remote builds in B6063: Diff 5113.Jun 6 2019, 4:27 PM
This revision was landed with ongoing or failed builds.Jun 6 2019, 4:37 PM
Closed by commit rDSTO710e0bfb288b: Add support for omitting origin type when calling origin_get. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
swh-public-ci added a comment.Jun 6 2019, 4:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/455/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/455/console

Harbormaster failed remote builds in B6066: Diff 5117!Jun 6 2019, 4:40 PM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
13 lines
swh/
storage/
3 lines
21 lines
sql/
1 line
3 lines
15 lines
tests/
31 lines

Diff 5118

View Options

sql/upgrades/135.sql

Loading...
View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/10-swh-init.sql

Loading...
View Options

swh/storage/sql/60-swh-indexes.sql

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal