Page MenuHomeSoftware Heritage

Add support for omitting origin type when calling origin_get.
ClosedPublic

Authored by vlorentz on Thu, Jun 6, 4:14 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Jun 6, 4:14 PM
vlorentz updated this revision to Diff 5113.Thu, Jun 6, 4:16 PM

add 'create extension' in migration script.

ardumont added inline comments.
sql/upgrades/135.sql
8

135?

10

I think that needs to run as postgres user.
So not sure if that needs to be declared here, maybe in comments instead?

vlorentz updated this revision to Diff 5117.Thu, Jun 6, 4:21 PM

fix version number

vlorentz marked an inline comment as done.Thu, Jun 6, 4:22 PM
vlorentz added inline comments.
sql/upgrades/135.sql
10

create extension statements are in swh/storage/sql/ same as everything else, so it's consistent to put that in the migration script.

ardumont added inline comments.Thu, Jun 6, 4:24 PM
sql/upgrades/135.sql
10

Yes.
My doubt is not about consistency, it's about running when applied during migration.
But meh ;)

ardumont accepted this revision.Thu, Jun 6, 4:25 PM
This revision is now accepted and ready to land.Thu, Jun 6, 4:25 PM
This revision was landed with ongoing or failed builds.Thu, Jun 6, 4:37 PM
This revision was automatically updated to reflect the committed changes.