Differential D1538

Add test for date parsing of origin_visit_add.
ClosedPublic
Actions

Authored by vlorentz on Jun 5 2019, 11:35 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Summary

Related: D1537

Diff Detail

Repository

rDSTO Storage manager

Branch

origin_visit_add_parse_date

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6018
Build 8269: tox-on-jenkins	Jenkins
Build 8268: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 5 2019, 11:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2019, 11:35 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/436/ for more details.

Harbormaster completed remote builds in B6018: Diff 5071.Jun 5 2019, 11:47 AM

douardda requested changes to this revision.Jun 12 2019, 11:54 AM

douardda added a subscriber: douardda.

douardda added inline comments.

swh/storage/tests/test_storage.py
1390	as I already said in another diff (IIRC), I'd like to see the tested date written as a literal string here. TBH I do not like that much using these self.date_visit* member variables. There is no gain in using these rather than literals and it obfuscate (slightly) the code of these tests (which generally is tedious enough as is).

This revision now requires changes to proceed.Jun 12 2019, 11:54 AM

rebase
use a literal string

vlorentz marked an inline comment as done.Jun 12 2019, 3:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/475/ for more details.

Harbormaster completed remote builds in B6170: Diff 5197.Jun 12 2019, 3:35 PM

douardda accepted this revision.Jun 13 2019, 2:02 PM

This revision is now accepted and ready to land.Jun 13 2019, 2:02 PM

Landed in 5e16e602f39667236eb8064732d2c3f4032b1e59

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

43 lines

Diff 5071

swh/storage/tests/test_storage.py

Loading...