Page MenuHomeSoftware Heritage
Differential D1523

Add origin persistent identifiers.
ClosedPublic
Actions

Authored by vlorentz on May 29 2019, 4:16 PM.

Details

Reviewers
zack
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1731: Intrinsic identifiers for origins
Commits
rDMOD67fade5f674a: Add origin persistent identifiers.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 29 2019, 4:16 PM
vlorentz added 1 blocking reviewer(s): zack.May 29 2019, 4:16 PM
swh-public-ci added a comment.May 29 2019, 4:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/79/ for more details.

Harbormaster completed remote builds in B5970: Diff 5019.May 29 2019, 4:17 PM
vlorentz added a task: T1731: Intrinsic identifiers for origins.May 29 2019, 6:04 PM
ardumont requested changes to this revision.May 30 2019, 10:43 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
docs/persistent-identifiers.rst
45

"ori" (* origin *)

;)

This revision now requires changes to proceed.May 30 2019, 10:43 AM
vlorentz updated this revision to Diff 5042.Jun 3 2019, 5:51 PM

fix typo

vlorentz marked an inline comment as done.Jun 3 2019, 5:51 PM
swh-public-ci added a comment.Jun 3 2019, 5:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/81/ for more details.

Harbormaster completed remote builds in B5993: Diff 5042.Jun 3 2019, 5:52 PM
ardumont added inline comments.Jun 3 2019, 6:16 PM
swh/model/tests/test_identifiers.py
900

Drop the type if it is not used.

ardumont added a comment.Jun 3 2019, 6:16 PM

Drop the type if it is not used.

Sorry, i thought i submitted it earlier...

ardumont accepted this revision.Jun 3 2019, 6:18 PM
vlorentz abandoned this revision.Jun 5 2019, 11:48 AM

Abandoning this diff, following discussion on T1731.

zack mentioned this in T1731: Intrinsic identifiers for origins.Jul 8 2019, 11:25 AM
vlorentz reclaimed this revision.Jul 10 2019, 3:09 PM
vlorentz updated this revision to Diff 5755.Jul 10 2019, 3:10 PM

rebase

vlorentz updated this revision to Diff 5756.Jul 10 2019, 3:11 PM

drop origin type.

vlorentz marked an inline comment as done.Jul 10 2019, 3:11 PM
swh-public-ci added a comment.Jul 10 2019, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/93/ for more details.

Harbormaster completed remote builds in B6776: Diff 5755.Jul 10 2019, 3:11 PM
swh-public-ci added a comment.Jul 10 2019, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/94/ for more details.

Harbormaster completed remote builds in B6777: Diff 5756.Jul 10 2019, 3:11 PM
ardumont accepted this revision.Jul 10 2019, 3:13 PM
zack accepted this revision.Jul 10 2019, 3:35 PM
This revision is now accepted and ready to land.Jul 10 2019, 3:35 PM
vlorentz updated this revision to Diff 5757.Jul 10 2019, 3:39 PM

rebase

This revision was landed with ongoing or failed builds.Jul 10 2019, 3:39 PM
Closed by commit rDMOD67fade5f674a: Add origin persistent identifiers. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B6778: Diff 5757!Jul 10 2019, 3:39 PM
swh-public-ci added a comment.Jul 10 2019, 3:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/95/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/95/console

Revision Contents
Changeset List

PathSize
docs/
11 lines
swh/
model/
13 lines
tests/
11 lines

Diff 5758

View Options

docs/persistent-identifiers.rst

Loading...
View Options

swh/model/identifiers.py

Loading...
View Options

swh/model/tests/test_identifiers.py

Loading...
About · Developer information · Legal