Page MenuHomeSoftware Heritage

Add origin persistent identifiers.
ClosedPublic

Authored by vlorentz on May 29 2019, 4:16 PM.

Diff Detail

Repository
rDMOD Data Model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 29 2019, 4:16 PM
vlorentz added 1 blocking reviewer(s): zack.May 29 2019, 4:16 PM
ardumont requested changes to this revision.May 30 2019, 10:43 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
docs/persistent-identifiers.rst
46

"ori" (* origin *)

;)

This revision now requires changes to proceed.May 30 2019, 10:43 AM
vlorentz updated this revision to Diff 5042.Jun 3 2019, 5:51 PM

fix typo

vlorentz marked an inline comment as done.Jun 3 2019, 5:51 PM
ardumont added inline comments.Jun 3 2019, 6:16 PM
swh/model/tests/test_identifiers.py
901

Drop the type if it is not used.

Drop the type if it is not used.

Sorry, i thought i submitted it earlier...

ardumont accepted this revision.Jun 3 2019, 6:18 PM
vlorentz abandoned this revision.Jun 5 2019, 11:48 AM

Abandoning this diff, following discussion on T1731.

vlorentz reclaimed this revision.Jul 10 2019, 3:09 PM
vlorentz updated this revision to Diff 5756.Jul 10 2019, 3:11 PM

drop origin type.

vlorentz marked an inline comment as done.Jul 10 2019, 3:11 PM
ardumont accepted this revision.Jul 10 2019, 3:13 PM
zack accepted this revision.Jul 10 2019, 3:35 PM
This revision is now accepted and ready to land.Jul 10 2019, 3:35 PM
This revision was landed with ongoing or failed builds.Jul 10 2019, 3:39 PM
This revision was automatically updated to reflect the committed changes.