Hide beta ribbon for non-large screens
AbandonedPublic
Actions

Authored by kalpitk on May 22 2019, 6:26 PM.

Details

Reviewers

Group Reviewers

Summary

Since "beta version" ribbon obstructs view on medium and small screens, hide it for smaller than large screens
Related T1477

Diff Detail

Repository

rDWAPPS Web applications

Branch

betaRibbon

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5888
Build 8070: tox-on-jenkins	Jenkins
Build 8069: arc lint + arc unit

Event Timeline

kalpitk created this revision.May 22 2019, 6:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 22 2019, 6:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/444/ for more details.

Harbormaster completed remote builds in B5888: Diff 4949.May 22 2019, 6:31 PM

Instead of hiding the ribbon, we should make it smaller in order that it does not overflow the main page content.
After thoughts, the fact that the the archive website is an ongoing development should remain visible to the users.
Can you try that approach ?

Also can you hide the 'Donate button' for smaller display ?

This revision now requires changes to proceed.May 23 2019, 2:29 PM

In D1505#33653, @anlambert wrote:

Instead of hiding the ribbon, we should make it smaller in order that it does not overflow the main page content.
After thoughts, the fact that the the archive website is an ongoing development should remain visible to the users.
Can you try that approach ?

Also can you hide the 'Donate button' for smaller display ?

Ok. Will update accordingly

By mistake pushed a new diff.
Changes made in D1510.

Revision Contents
Changeset List

Path

Size

swh/

web/

templates/

browse/

layout.html

2 lines

Diff 4949

View Options

swh/web/templates/browse/layout.html

Hide beta ribbon for non-large screensAbandonedPublicActions