Page MenuHomeSoftware Heritage
Differential D1455

Remove language indexer.
ClosedPublic
Actions

Authored by vlorentz on May 9 2019, 2:57 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDX58627ee48bb3: Remove language indexer.
Summary

It has always been unreliable, and its tests are broken since
Pygments v2.4.0.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 9 2019, 2:57 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 9 2019, 2:57 PM
swh-public-ci added a comment.May 9 2019, 3:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/527/ for more details.

Harbormaster completed remote builds in B5651: Diff 4755.May 9 2019, 3:00 PM
olasd requested changes to this revision.May 9 2019, 3:08 PM
olasd added a subscriber: olasd.

I think you can remove pygments and chardet from requirements.txt ?

This revision now requires changes to proceed.May 9 2019, 3:08 PM
vlorentz updated this revision to Diff 4756.May 9 2019, 3:13 PM

rm deps

swh-public-ci added a comment.May 9 2019, 3:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/528/ for more details.

Harbormaster completed remote builds in B5652: Diff 4756.May 9 2019, 3:16 PM
olasd accepted this revision.May 9 2019, 3:16 PM
This revision is now accepted and ready to land.May 9 2019, 3:16 PM
vlorentz updated this revision to Diff 4757.May 9 2019, 3:17 PM

rebase

This revision was landed with ongoing or failed builds.May 9 2019, 3:17 PM
Closed by commit rDCIDX58627ee48bb3: Remove language indexer. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B5653: Diff 4757!May 9 2019, 3:17 PM
swh-public-ci added a comment.May 9 2019, 3:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/529/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/529/console

Revision Contents
Changeset List

PathSize
2 lines
swh/
indexer/
7 lines
7 lines
tests/

Diff 4758

View Options

requirements.txt

Loading...
View Options

swh/indexer/ctags.py

Loading...
View Options

swh/indexer/language.py

Loading...
View Options

swh/indexer/tasks.py

Loading...
View Options

swh/indexer/tests/test_language.py

Loading...
About · Developer information · Legal