listener: Release the db object after using it
ClosedPublic
Actions

Authored by olasd on May 7 2019, 6:17 PM.

Details

Reviewers

vlorentz

Commits

rDSCHac1b8db829fa: listener: Release the db object after using it

Summary

This is the contract that get_db/put_db is supposed to conform to.

Test Plan

tox is still happy; we can process more than ten pending messages at once

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.May 7 2019, 6:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/256/ for more details.

Harbormaster completed remote builds in B5636: Diff 4742.May 7 2019, 6:20 PM

It should probably be in a finally block.

Less improper database exception handling

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/257/ for more details.

Harbormaster completed remote builds in B5680: Diff 4777.May 10 2019, 2:41 PM

vlorentz accepted this revision.May 10 2019, 3:52 PM

This revision is now accepted and ready to land.May 10 2019, 3:52 PM

Rrrrrebase

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/258/ for more details.

Harbormaster completed remote builds in B5682: Diff 4779.May 10 2019, 3:55 PM

Closed by commit rDSCHac1b8db829fa: listener: Release the db object after using it (authored by olasd). · Explain WhyMay 10 2019, 5:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

celery_backend/

listener.py

27 lines

Diff 4780

View Options

swh/scheduler/celery_backend/listener.py

listener: Release the db object after using itClosedPublicActions