Page MenuHomeSoftware Heritage
Differential D1436

tests: Add integration tests for the Software Heritage stack
ClosedPublic
Actions

Authored by anlambert on Apr 26 2019, 5:33 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDENV5c9b912b4bc4: tests: Add integration tests for the Software Heritage stack
rCDFD5c9b912b4bc4: tests: Add integration tests for the Software Heritage stack
Summary

First draft of integration tests for the Software Heritage stack using the
docker-compose environment and a couple of bash scripts.

Their purpose is to:

  • ensure the docker-compose environment is up to date and running
  • check there is no regression in high level Software Heritage features (loading origins, querying web api, vault cooking, ...)

The tests will fail if:

  • any of the swh service dies unexpectedly
  • any of the command in the test scripts exits with error

First written tests are about the loading of git origins and vault cooking.

To execute the tests, simply execute the run_tests.sh script.

Related T1618

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 26 2019, 5:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 26 2019, 5:33 PM
Harbormaster completed remote builds in B5546: Diff 4665.Apr 26 2019, 5:33 PM
anlambert edited the summary of this revision. (Show Details)Apr 26 2019, 5:34 PM
anlambert updated this revision to Diff 4666.Apr 26 2019, 7:00 PM

Update: Remove the use of docker-compose.override.yml file in the tests

Harbormaster completed remote builds in B5547: Diff 4666.Apr 26 2019, 7:00 PM
anlambert updated this revision to Diff 4667.Apr 26 2019, 7:38 PM

Update: Ensure all swh services are up before running the tests

Harbormaster completed remote builds in B5548: Diff 4667.Apr 26 2019, 7:38 PM
vlorentz added a subscriber: vlorentz.May 6 2019, 10:47 AM

lgtm, but why bash instead of python?

anlambert added a comment.May 6 2019, 11:21 AM

Because I think that bash is more adequate when one only wants to run a couple of shell commands sequentially
and process their output / return code. The main idea here is "run a specific swh processing, exit with error
if something went wrong".

This tests implementation already enables me to find issues in our stack (see D1435 for instance).

douardda accepted this revision.May 9 2019, 9:28 AM
This revision is now accepted and ready to land.May 9 2019, 9:28 AM
anlambert updated this revision to Diff 4761.May 9 2019, 6:08 PM

Update:

  • improve wait_for_service_output implementation
  • dump logs to a file on error
Harbormaster completed remote builds in B5657: Diff 4761.May 9 2019, 6:08 PM
Closed by commit rCDFD5c9b912b4bc4: tests: Add integration tests for the Software Heritage stack (authored by anlambert). · Explain WhyMay 10 2019, 1:25 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDENV5c9b912b4bc4: tests: Add integration tests for the Software Heritage stack.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
3 lines
tests/
167 lines
70 lines
26 lines

Diff 4775

View Options

.gitignore

Loading...
View Options

tests/run_tests.sh

Loading...
View Options

tests/test_01_loader_git.sh

Loading...
View Options

tests/test_02_vault.sh

Loading...
About · Developer information · Legal