Use the proper order to record content byte addition
ClosedPublic
Actions

Authored by olasd on Apr 11 2019, 12:18 PM.

Details

Reviewers

Commits

rDSTOC58b49f9a8429: Use the proper order to record content byte addition
rDSTO58b49f9a8429: Use the proper order to record content byte addition

Summary

The current way the value is returned creates a metric whose name is backwards.

Test Plan

tox and looking at prometheus data

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5352
Build 7261: tox-on-jenkins	Jenkins
Build 7260: arc lint + arc unit

Event Timeline

olasd created this revision.Apr 11 2019, 12:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/359/ for more details.

Harbormaster completed remote builds in B5334: Diff 4525.Apr 11 2019, 12:24 PM

ardumont accepted this revision.Apr 11 2019, 6:10 PM

This revision is now accepted and ready to land.Apr 11 2019, 6:10 PM

re-re-re your base, gently down the stream

This revision was landed with ongoing or failed builds.Apr 12 2019, 11:34 AM

Closed by commit rDSTO58b49f9a8429: Use the proper order to record content byte addition (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B5352: Diff 4543.Apr 12 2019, 11:40 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/363/ for more details.

Revision Contents
Changeset List

Path

Size

swh/

storage/

in_memory.py

2 lines

storage.py

4 lines

tests/

test_storage.py

12 lines

Diff 4543

View Options

swh/storage/in_memory.py

View Options

swh/storage/storage.py

View Options

swh/storage/tests/test_storage.py

Use the proper order to record content byte additionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4543

swh/storage/in_memory.py

swh/storage/storage.py

swh/storage/tests/test_storage.py

Use the proper order to record content byte addition
ClosedPublic
Actions

Revision Contents
Changeset List