Page MenuHomeSoftware Heritage
Differential D1403

conf/loader.yml: Add npm loader task configuration
ClosedPublic
Actions

Authored by anlambert on Apr 11 2019, 10:56 AM.

Details

Reviewers
ardumont
olasd
Group Reviewers
Reviewers
Commits
rDENVca58318d9a24: Add npm loader and its configuration
rCDFDca58318d9a24: Add npm loader and its configuration
Summary

Related T1631

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 11 2019, 10:56 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 11 2019, 10:56 AM
Harbormaster completed remote builds in B5325: Diff 4517.Apr 11 2019, 10:56 AM
ardumont accepted this revision.Apr 11 2019, 11:35 AM
This revision is now accepted and ready to land.Apr 11 2019, 11:35 AM
olasd requested changes to this revision.Apr 11 2019, 4:05 PM
olasd added a subscriber: olasd.

This is missing the addition of swh-loader-npm to the Dockerfile

This revision now requires changes to proceed.Apr 11 2019, 4:05 PM
anlambert updated this revision to Diff 4530.Apr 11 2019, 4:10 PM

Update: Install swh-loader-npm in the Dockerfile (did not spot this due to the local mount of it through my docker-compose.override.yml file)

Harbormaster completed remote builds in B5339: Diff 4530.Apr 11 2019, 4:10 PM
olasd accepted this revision.Apr 11 2019, 4:11 PM

This seems to work for me, thanks!

This revision is now accepted and ready to land.Apr 11 2019, 4:11 PM
Closed by commit rCDFDca58318d9a24: Add npm loader and its configuration (authored by anlambert). · Explain WhyApr 11 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDENVca58318d9a24: Add npm loader and its configuration.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
1 line
conf/
3 lines

Diff 4531

View Options

Dockerfile

Loading...
View Options

conf/loader.yml

Loading...
About · Developer information · Legal