Page MenuHomeSoftware Heritage
Differential D1374

docker-compose: Remove storage listener and journal publisher
ClosedPublic
Actions

Authored by ardumont on Apr 9 2019, 1:14 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDENVadeb8787f629: docker-compose: Remove journal client sample
rDENVa1beb091c9ec: docker-compose: Remove storage listener and journal publisher
rCDFDadeb8787f629: docker-compose: Remove journal client sample
rCDFDa1beb091c9ec: docker-compose: Remove storage listener and journal publisher
Summary

Also Remove journal client sample

Related D1370
Related D1371
Related D1372

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Apr 9 2019, 1:14 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 1:14 PM
Harbormaster completed remote builds in B5221: Diff 4414.Apr 9 2019, 1:14 PM
ardumont mentioned this in D1359: [docker-compose] Update kafka based services configuration.Apr 9 2019, 1:17 PM
anlambert requested changes to this revision.Apr 9 2019, 1:40 PM
anlambert added a subscriber: anlambert.

You should also remove the related configuration files: conf/journal_publisher.yml and conf/journal_client.yml.

The file services/indexer-journal-client/journal_client.yml should also be moved to conf/indexer_journal-client.yml for more consistency.

This revision now requires changes to proceed.Apr 9 2019, 1:40 PM
ardumont added a comment.Apr 9 2019, 1:43 PM
In D1374#29834, @anlambert wrote:

You should also remove the related configuration files: conf/journal_publisher.yml and conf/journal_client.yml.

The file services/indexer-journal-client/journal_client.yml should also be moved to conf/indexer_journal-client.yml for more consistency.

Doh', right!

.oO(so much for doing too much stuff in //)

Thanks for the heads up!

ardumont updated this revision to Diff 4416.Apr 9 2019, 1:53 PM

Remove no longer needed configuration files and rebase on latest master

fun fact: It was ongoing on my machine and forgot to complete it
(removing those files) prior to create the diff.

Harbormaster completed remote builds in B5222: Diff 4416.Apr 9 2019, 1:53 PM
anlambert accepted this revision.Apr 9 2019, 2:02 PM
This revision is now accepted and ready to land.Apr 9 2019, 2:02 PM
Closed by commit rCDFDa1beb091c9ec: docker-compose: Remove storage listener and journal publisher (authored by ardumont). · Explain WhyApr 9 2019, 2:06 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDENVa1beb091c9ec: docker-compose: Remove storage listener and journal publisher.Nov 26 2019, 1:35 PM
ardumont added a commit: rDENVadeb8787f629: docker-compose: Remove journal client sample.

Revision Contents
Changeset List

Diff 4417

View Options

Dockerfile

Loading...
View Options

conf/journal_publisher.yml

Loading...
View Options

conf/storage_listener.yml

Loading...
View Options

docker-compose.yml

Loading...
About · Developer information · Legal