Mark the graph node id columns as not null
ClosedPublic
Actions

Authored by olasd on Mar 25 2019, 4:27 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOCaaab31cc20e4: Mark the node id columns as not null for directory, revision and snapshot
R65:aaab31cc20e4: Mark the node id columns as not null for directory, revision and snapshot
rDSTOaaab31cc20e4: Mark the node id columns as not null for directory, revision and snapshot

Summary

This is an oversight from the migration to split indexes.

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4831
Build 6433: tox-on-jenkins	Jenkins
Build 6432: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 25 2019, 4:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2019, 4:27 PM

This doesn't warrant an increment of the schema version as this is already implied by the fact that we set this column as the primary key of the table in the indexes.sql.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/219/ for more details.

Harbormaster completed remote builds in B4830: Diff 4084.Mar 25 2019, 4:30 PM

Add not null to more id columns

olasd retitled this revision from Mark the directory id column as not null to Mark the graph node id columns as not null.Mar 25 2019, 4:32 PM

vlorentz accepted this revision.Mar 25 2019, 4:34 PM

This revision is now accepted and ready to land.Mar 25 2019, 4:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/220/ for more details.

Harbormaster completed remote builds in B4831: Diff 4085.Mar 25 2019, 4:35 PM

Closed by commit rDSTOaaab31cc20e4: Mark the node id columns as not null for directory, revision and snapshot (authored by olasd). · Explain WhyMar 25 2019, 4:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

sql/

30-swh-schema.sql

10 lines

Diff 4085

View Options

swh/storage/sql/30-swh-schema.sql

Mark the graph node id columns as not nullClosedPublicActions