Differential D1272

tests: refactorings
ClosedPublic
Actions

Authored by douardda on Mar 19 2019, 12:13 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDOBJS771152280352: tests: small refactorings
rDOBJS9b29b475898e: tests: improve a bit the test_get_stream test
rDOBJS584449c0971d: tests: skip deletion related tests for the remote api

Summary

skip deletion related tests for the remote api
small refactorings
improve a bit the test_get_stream test

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 19 2019, 12:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 19 2019, 12:13 PM

Harbormaster failed remote builds in B4721: Diff 4005!Mar 19 2019, 12:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/24/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/24/console

vlorentz accepted this revision.Mar 19 2019, 12:18 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/objstorage/tests/objstorage_testing.py
157 ↗	(On Diff #4005)	assertIsInstance
swh/objstorage/tests/test_objstorage_api.py
45–49	nitpick: I use a decorator in swh-storage: https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/tests/test_api_client.py$61

This revision is now accepted and ready to land.Mar 19 2019, 12:18 PM

douardda marked 2 inline comments as done.Mar 20 2019, 12:16 PM

douardda added inline comments.

swh/objstorage/tests/objstorage_testing.py
157 ↗	(On Diff #4005)	if I have a bit more courage, it would be a simple assert statement (ie. convert the whole test to pytest...) so
swh/objstorage/tests/test_objstorage_api.py
45–49	and you are right to do so

use pytest.mark.skip as suggested by vlorentz

Closed by commit rDOBJS584449c0971d: tests: skip deletion related tests for the remote api (authored by douardda). · Explain WhyMar 27 2019, 10:57 AM

This revision was automatically updated to reflect the committed changes.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/31/console

Harbormaster failed remote builds in B4846: Diff 4100!Mar 27 2019, 10:58 AM

Revision Contents
Changeset List

Path

Size

swh/

objstorage/

tests/

test_objstorage_api.py

9 lines

Diff 4101

swh/objstorage/tests/test_objstorage_api.py

Loading...