Differential D1246

[swh-web] Switch back to classical links in table rows
ClosedPublic
Actions

Authored by anlambert on Mar 14 2019, 8:47 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS7483a7eaf45b: assets/templates: Switch back to classical links in table rows

Summary

Revert modifications introduced in 1dab1b07c097 as it was not a good idea
thinking it back. In particular, navigating the webapp using the keyboard
was not optimal at all.

Also reinstate the link outlines in order to clearly see which link is
currently focused when navigating through the keyboard.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 14 2019, 8:47 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 14 2019, 8:47 PM

Harbormaster failed remote builds in B4652: Diff 3937!Mar 14 2019, 8:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/249/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/249/console

vlorentz accepted this revision.Mar 15 2019, 4:34 PM

This revision is now accepted and ready to land.Mar 15 2019, 4:34 PM

Rebase

Closed by commit rDWAPPS7483a7eaf45b: assets/templates: Switch back to classical links in table rows (authored by anlambert). · Explain WhyMar 15 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/332/ for more details.

Harbormaster completed remote builds in B4674: Diff 3960.Mar 15 2019, 5:44 PM

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

browse/

browse.css

17 lines

origin-search.js

7 lines

snapshot-navigation.css

6 lines

revision/

log-utils.js

1 line

webapp/

webapp-utils.js

8 lines

webapp.css

9 lines

utils/

showdown.css

1 line

templates/

api/

endpoints.html

4 lines

browse/

branches.html

14 lines

releases.html

13 lines

revision-log.html

18 lines

includes/

directory-display.html

21 lines

Diff 3961

View Options

swh/web/assets/src/bundles/browse/browse.css

View Options

swh/web/assets/src/bundles/browse/origin-search.js

View Options

swh/web/assets/src/bundles/browse/snapshot-navigation.css

View Options

swh/web/assets/src/bundles/revision/log-utils.js

View Options

swh/web/assets/src/bundles/webapp/webapp-utils.js

View Options

swh/web/assets/src/bundles/webapp/webapp.css

View Options

swh/web/assets/src/utils/showdown.css

View Options

swh/web/templates/api/endpoints.html

View Options

swh/web/templates/browse/branches.html

View Options

swh/web/templates/browse/releases.html

View Options

swh/web/templates/browse/revision-log.html

View Options

swh/web/templates/includes/directory-display.html

[swh-web] Switch back to classical links in table rowsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3961

swh/web/assets/src/bundles/browse/browse.css

swh/web/assets/src/bundles/browse/origin-search.js

swh/web/assets/src/bundles/browse/snapshot-navigation.css

swh/web/assets/src/bundles/revision/log-utils.js

swh/web/assets/src/bundles/webapp/webapp-utils.js

swh/web/assets/src/bundles/webapp/webapp.css

swh/web/assets/src/utils/showdown.css

swh/web/templates/api/endpoints.html

swh/web/templates/browse/branches.html

swh/web/templates/browse/releases.html

swh/web/templates/browse/revision-log.html

swh/web/templates/includes/directory-display.html

[swh-web] Switch back to classical links in table rows
ClosedPublic
Actions

Revision Contents
Changeset List